From 1d82f1a74b5cd80c463ba2547af07cf8a878bbdf Mon Sep 17 00:00:00 2001 From: Rouslan Solomakhin Date: Tue, 3 Oct 2023 15:10:06 +0000 Subject: [PATCH] Gardening: Disable LcpBreakdownTimingsTest.ManualLazyLoadingImage on Chrome OS Owners-Override: Gardening. Bug: 1487837 Change-Id: Id4fc06cee426aaa3e5f78d36f264b6963f3ad85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902451 Reviewed-by: Charlie Harrison Commit-Queue: Rouslan Solomakhin Cr-Commit-Position: refs/heads/main@{#1204654} --- .../largest_contentful_paint_browsertest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/chrome/browser/page_load_metrics/integration_tests/largest_contentful_paint_browsertest.cc b/chrome/browser/page_load_metrics/integration_tests/largest_contentful_paint_browsertest.cc index 712701a1081270..71160c0f9a90fe 100644 --- a/chrome/browser/page_load_metrics/integration_tests/largest_contentful_paint_browsertest.cc +++ b/chrome/browser/page_load_metrics/integration_tests/largest_contentful_paint_browsertest.cc @@ -1200,8 +1200,9 @@ IN_PROC_BROWSER_TEST_F(LcpBreakdownTimingsTest, MAYBE_NativeLazyLoadingImage) { Validate(); } -// TODO(https://crbug.com/1487837): This test is failing on Linux CFI. -#if BUILDFLAG(IS_CHROMEOS_LACROS) || BUILDFLAG(IS_LINUX) +// TODO(https://crbug.com/1487837): This test is failing on Linux CFI and Chrome +// OS (Both Lacros and ASH). +#if BUILDFLAG(IS_CHROMEOS) || BUILDFLAG(IS_LINUX) #define MAYBE_ManualLazyLoadingImage DISABLED_ManualLazyLoadingImage #else #define MAYBE_ManualLazyLoadingImage ManualLazyLoadingImage