From 19f479b82f6e8c192a9eb5e6daab8ab9d4a257c3 Mon Sep 17 00:00:00 2001 From: Peter Kvitek Date: Tue, 24 Jul 2018 21:15:19 +0000 Subject: [PATCH] Added dump-devtools-protocol command line switch. Inspecting protocol log is a great way to analyze what's going on under the hood of a test and should be instantly available. Change-Id: I238499f50074cc1eb6b6666ecc19b2fce17ddbe6 Reviewed-on: https://chromium-review.googlesource.com/1147752 Reviewed-by: Andrey Kosyakov Commit-Queue: Peter Kvitek Cr-Commit-Position: refs/heads/master@{#577684} --- headless/test/headless_protocol_browsertest.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/headless/test/headless_protocol_browsertest.cc b/headless/test/headless_protocol_browsertest.cc index 27b42ec73a7073..f6b38e92604402 100644 --- a/headless/test/headless_protocol_browsertest.cc +++ b/headless/test/headless_protocol_browsertest.cc @@ -33,6 +33,7 @@ namespace headless { namespace { static const char kResetResults[] = "reset-results"; +static const char kDumpDevToolsProtocol[] = "dump-devtools-protocol"; } // namespace class HeadlessProtocolBrowserTest @@ -112,6 +113,10 @@ class HeadlessProtocolBrowserTest } if (method != "DONE") { + if (base::CommandLine::ForCurrentProcess()->HasSwitch( + kDumpDevToolsProtocol)) { + LOG(INFO) << "FromJS: " << json_message; + } // Pass unhandled commands onto the inspector. browser_devtools_client_->SendRawDevToolsMessage(json_message); return; @@ -156,6 +161,12 @@ class HeadlessProtocolBrowserTest void SendMessageToJS(const std::string& message) { if (test_finished_) return; + + if (base::CommandLine::ForCurrentProcess()->HasSwitch( + kDumpDevToolsProtocol)) { + LOG(INFO) << "ToJS: " << message; + } + std::string encoded; base::Base64Encode(message, &encoded); devtools_client_->GetRuntime()->Evaluate("onmessage(atob(\"" + encoded +