From 05c600934b3621eca899f7223f763f05e863d68e Mon Sep 17 00:00:00 2001 From: Peter Wen Date: Mon, 22 Oct 2018 20:18:26 +0000 Subject: [PATCH] Android: Update android_deps roll README Including warning and mitigation for errors. Bug: 877956 Change-Id: Id0abfce282d6f3a15ee5a9d4a70751839f2946a2 Reviewed-on: https://chromium-review.googlesource.com/c/1294592 Reviewed-by: Mohamed Heikal Commit-Queue: Mohamed Heikal Cr-Commit-Position: refs/heads/master@{#601705} --- tools/android/roll/android_deps/README.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/android/roll/android_deps/README.md b/tools/android/roll/android_deps/README.md index b2d81cf54a44b3..fe37c23ae41ef5 100644 --- a/tools/android/roll/android_deps/README.md +++ b/tools/android/roll/android_deps/README.md @@ -37,9 +37,20 @@ Full steps to add a new third party library: - Before running this command, make sure to increment the `CIPD_SUFFIX` variable in `BuildConfigGenerator.groovy` in order to ensure that each tag in CIPD is unique. + - One option to thoroughly test your change is to run + `rm -rf third_party/android_deps/libs/[!O]*` before running with + `--update-all`. This will ensure all your deps are fresh. The commands + printed out in the following step will ensure you do not upload + duplicate instances. 4. Run the commands printed at step 3 to create new and updated packages via cipd. + - In order to do this, you will need write access. Ask anyone from this + [list][owners_link] to add you to the group. + - Just make sure to copy the commands exactly, as uploading an instance + with the same package and tag as an existing instance currently in use + can break all builds, and there is no easy way to delete an instance. + - If this happens, file an infra-trooper bug immediately. 5. Create a commit & follow [`//docs/adding_to_third_party.md`][docs_link] for the review. @@ -57,6 +68,7 @@ file that they use, explained in the [README.chromium][readme_chromium_link] is up-to-date with the one on android's [website][android_sdk_link], last updated date is at the bottom. +[owners_link]: http://go/android-deps-owners [docs_link]: ../../../../docs/adding_to_third_party.md [android_sdk_link]: https://developer.android.com/studio/terms [readme_chromium_link]: ../../../../third_party/android_deps/README.chromium