Skip to content

Issue/331 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 6, 2022
Merged

Issue/331 #373

merged 14 commits into from
Nov 6, 2022

Conversation

@ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Nov 3, 2022 •
edited
Loading

This PR will resolve #331

  • It provides a wrapper for settings storage
  • It provides a one-time import of legacy settings data
  • It provides a ability to reset all/part/single settings
  • Compatibility functions to make existing frontends work
  • Some new settings and labels are preset (not used yet, and will be adjusted in other subsequent refactorings)
  • This is an internal backend refactoring to provide the foundation for other changes

@ACTCD ACTCD requested a review from quoid November 3, 2022 22:06
quoid
quoid requested changes Nov 4, 2022
View reviewed changes
@ACTCD ACTCD requested a review from quoid November 5, 2022 00:49
@ACTCD ACTCD marked this pull request as ready for review November 5, 2022 01:53
ACTCD and others added 2 commits November 5, 2022 12:23
@ACTCD ACTCD merged commit 9be70e5 into quoid:master Nov 6, 2022
@ACTCD ACTCD deleted the issue/331 branch November 6, 2022 13:58
@ACTCD ACTCD mentioned this pull request Nov 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quoid quoid quoid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Save extension settings to browser.storage

2 participants

@ACTCD @quoid