Skip to content

Conversation

@drernie
Copy link
Member

@drernie drernie commented Dec 11, 2025

Summary

  • Clarifies that public subnets are used for accessing the validation server, which also handles sending password reset emails

Test plan

  • Documentation change only

🤖 Generated with Claude Code

Greptile Overview

Greptile Summary

This PR adds documentation clarifying that public subnets in a Quilt-created VPC are used for accessing the validation server, which also handles sending password reset emails.

  • Updates docs/Architecture.md to explain why public subnets are needed beyond just NAT gateways and the load balancer
  • Documentation-only change with no code impact

Confidence Score: 5/5

  • This PR is safe to merge - documentation-only change with no code impact
  • Score of 5 reflects that this is a simple documentation clarification with no code changes, no risk of breaking functionality, and adds helpful context for users understanding the network architecture
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docs/Architecture.md 5/5 Documentation-only change adding clarification about public subnet usage for accessing the validation server and password reset emails.

Sequence Diagram

sequenceDiagram
    participant User
    participant Internet
    participant PublicSubnet as Public Subnet (ALB, NAT)
    participant ValidationServer as Validation Server
    participant PrivateSubnet as Private Subnet (ECS/Lambda)
    
    User->>Internet: Password Reset Request
    Internet->>PublicSubnet: Route to ALB
    PublicSubnet->>ValidationServer: Handle Request
    ValidationServer->>User: Send Password Reset Email
    
    Note over PublicSubnet: Public subnets provide<br/>internet connectivity for<br/>validation server & emails
Loading

… emails

Clarify that the public subnets are used for NAT gateways, an internet-facing
ALB for accessing the validation server, which also handles sending password
reset emails.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.57%. Comparing base (572d39c) to head (24045e9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4664   +/-   ##
=======================================
  Coverage   42.57%   42.57%           
=======================================
  Files         790      790           
  Lines       31642    31642           
  Branches     5692     5692           
=======================================
  Hits        13473    13473           
  Misses      16177    16177           
  Partials     1992     1992           
Flag Coverage Δ
api-python 91.66% <ø> (ø)
catalog 19.34% <ø> (ø)
lambda 96.57% <ø> (ø)
py-shared 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

#### Subnet division when Quilt creates the VPC

- 2 public subnets for NAT gateways and an internet-facing application load balancer
for accessing the validation server, which also sends password reset emails
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it sounds quite misleading now

public subnets are needed for

  1. internet-facing application load balancer
  2. NAT gateways which are needed for accessing the validation server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants