Refactor datasource features as mixins #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelemeny
force-pushed
the
ddelemeny/refactor-datasource-mixins
branch
from
aabbb30 to
d11100f
Compare
fmassot
approved these changes
Feb 26, 2024
ddelemeny
force-pushed
the
ddelemeny/refactor-datasource-mixins
branch
from
d11100f to
21e582f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
A datasource is a complex class implementing various functional aspects.
On the abstract side, grafana splits the Datasource API into feature-sized interfaces.
Implementing features as mixins allow us to match that organization in our implementation, which hopefully translates into more readable code and more manageable chunks of logic as we implement more features.
It could also allow us to easily activate/deactivate a feature in a build, which may be handy when debugging and/or releasing.
See also : grafana/plugin-tools#783