Skip to content

Improve LuceneQueryEditor keyboard a11y, fixes #76 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2024
Merged

Improve LuceneQueryEditor keyboard a11y, fixes #76 #80

merged 4 commits into from
Feb 20, 2024

Conversation

@ddelemeny
Copy link
Collaborator

@ddelemeny ddelemeny commented Feb 19, 2024

  • Add Shift-Enter keymap to submit
  • Tab focuses next element instead of indenting (don't create a keyboard trap, indent is not mission-critical)

TODO :

  • Add usage hints in the placeholder (Ctrl-Space to autocomplete, `Shift-Enter to submit)

@ddelemeny ddelemeny force-pushed the ddelemeny/improve-editor-a11y branch from a5ab579 to 8678648 Compare February 19, 2024 21:09
@ddelemeny ddelemeny linked an issue Feb 19, 2024 that may be closed by this pull request
Trigger a search on key 'Shift-Enter' in lucene query editor #76
Closed
@fmassot fmassot merged commit 0c234f5 into main Feb 20, 2024
@ddelemeny ddelemeny deleted the ddelemeny/improve-editor-a11y branch February 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trigger a search on key 'Shift-Enter' in lucene query editor

3 participants

@ddelemeny @fmassot