i3/sway: fix crash due to newline breaking up an IPC message

Author: nydragon

src/x11/i3/ipc/connection.cpp

@@ -120,7 +120,7 @@ I3Ipc::I3Ipc() {
 
 void I3Ipc::eventSocketReady() {
 	while (true) {
-		auto rawEvent = this->liveEventSocket.readLine();
+		auto rawEvent = this->liveEventSocket.readAll();
 		if (rawEvent.isEmpty()) break;
 
 		for (auto& [type, data]: I3Ipc::parseResponse(rawEvent)) {
@@ -139,6 +139,13 @@ QVector<Event> I3Ipc::parseResponse(QByteArray rawEvent) {
 	const int header = 8 + magicLen;
 
 	while (rawEvent.startsWith(MAGIC)) {
+		auto eventLength = rawEvent.length();
+
+		if (eventLength < header) {
+			qCWarning(logI3Ipc) << "Event isn't long enough to hold the header data (14 bytes).";
+			break;
+		};
+
 		QDataStream ds(QByteArray(rawEvent.data() + magicLen, 8)); // NOLINT
 
 		ds.setByteOrder(static_cast<QDataStream::ByteOrder>(QSysInfo::ByteOrder));
@@ -151,7 +158,15 @@ QVector<Event> I3Ipc::parseResponse(QByteArray rawEvent) {
 
 		if (I3IpcEvent::intToEvent(type) == EventCode::UNKNOWN) {
 			qCWarning(logI3Ipc) << "Received unknown event" << rawEvent;
-			return events;
+			break;
+		}
+
+		auto maxPayloadLength = eventLength - header;
+
+		if (maxPayloadLength < size) {
+			qCWarning(logI3Ipc) << "Payload is smaller than length advertised in header, skipping... ("
+			                    << maxPayloadLength << "vs" << size << ")";
+			break;
 		}
 
 		auto byteData = QByteArray(rawEvent.data() + header, size); // NOLINT