Replies: 3 comments 17 replies
-
|
If you want to be thorough, the test262 suite should be run. There is a fast variant, but even the "slow" one is fast enough now, thanks to the multi-threading enhancements Ben made. |
Beta Was this translation helpful? Give feedback.
-
|
Yes @saghul . From what I see, even the CI for ubuntu-latest (Release) has failures similar to the above log (which unfortunately, got buried in the logs above, but I'll add it below for comparision). Result: 83/78324 errors, 3772 excluded, 5387 skipped, 83 newIt seems to be passing because the workflow runs Do I still add test262? Or should tests simply suffice, along with the standalone and api test? I also noticed that microbench is missing from the test? |
Beta Was this translation helpful? Give feedback.
-
|
They test different things. What you want to test for is kinda up to you. In general your results shouldn't differ from ours. Barring some very weird environment problems. Good catch on time, I'll take a look! |
Beta Was this translation helpful? Give feedback.
-
|
@saghul Since the upstream does not check for tests, I guess I can enable test262 for the next version when it is fixed, or else the package won't be accessible, right? Another issue (or maybe not) that I came across was at line 211 of test_std.js - which assumes I am also not sure if this is a issue or not, but when (list
...
#:configure-flags
#~(list "-DBUILD_SHARED_LIBS:BOOL=TRUE"
"-DQJS_BUILD_EXAMPLES:BOOL=TRUE"
"-DQJS_BUILD_CLI_WITH_MIMALLOC:BOOL=TRUE"
"-DQJS_ENABLE_ASAN:BOOL=TRUE"
"-DQJS_ENABLE_UBSAN:BOOL=TRUE"
;; MSAN and TSAN is perhaps not supported on gcc at the moment?
"-DQJS_ENABLE_MSAN:BOOL=FALSE"
"-DQJS_ENABLE_TSAN:BOOL=FALSE"
;; False because of linker issues
"-DQJS_BUILD_LIBC:BOOL=FALSE")
...
)Here's the log for the same:ld: CMakeFiles/function_source.dir/gen/function_source.c.o: in function `main':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:66:(.text.startup+0x20): undefined reference to `js_std_set_worker_new_context_func'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:67:(.text.startup+0x28): undefined reference to `js_std_init_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:68:(.text.startup+0x2f): undefined reference to `js_module_loader'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:70:(.text.startup+0x52): undefined reference to `js_std_add_helpers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:71:(.text.startup+0x66): undefined reference to `js_std_eval_binary'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:72:(.text.startup+0x6e): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:76:(.text.startup+0x7d): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/function_source.c:74:(.text.startup+0xa2): undefined reference to `js_std_dump_error'
ld: CMakeFiles/hello.dir/gen/hello.c.o: in function `main':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:38:(.text.startup+0x20): undefined reference to `js_std_set_worker_new_context_func'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:39:(.text.startup+0x28): undefined reference to `js_std_init_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:40:(.text.startup+0x2f): undefined reference to `js_module_loader'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:42:(.text.startup+0x52): undefined reference to `js_std_add_helpers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:43:(.text.startup+0x66): undefined reference to `js_std_eval_binary'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:44:(.text.startup+0x6e): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:48:(.text.startup+0x7d): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello.c:46:(.text.startup+0xa2): undefined reference to `js_std_dump_error'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/function_source.dir/build.make:101: function_source] Error 1
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:263: CMakeFiles/function_source.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/hello.dir/build.make:101: hello] Error 1
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:289: CMakeFiles/hello.dir/all] Error 2
ld: CMakeFiles/hello_module.dir/gen/hello_module.c.o: in function `JS_NewCustomContext':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:81:(.text+0x2a): undefined reference to `js_std_eval_binary'
ld: CMakeFiles/hello_module.dir/gen/hello_module.c.o: in function `main':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:92:(.text.startup+0x20): undefined reference to `js_std_set_worker_new_context_func'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:93:(.text.startup+0x28): undefined reference to `js_std_init_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:94:(.text.startup+0x2f): undefined reference to `js_module_loader'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:96:(.text.startup+0x52): undefined reference to `js_std_add_helpers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:97:(.text.startup+0x66): undefined reference to `js_std_eval_binary'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:98:(.text.startup+0x6e): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:102:(.text.startup+0x7d): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/hello_module.c:100:(.text.startup+0xa2): undefined reference to `js_std_dump_error'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/hello_module.dir/build.make:101: hello_module] Error 1
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:315: CMakeFiles/hello_module.dir/all] Error 2
[ 86%] Linking C executable test_fib
/gnu/store/2lxfijiqqljxdxr2ppqqrn5czkh4r1rq-cmake-minimal-3.24.2/bin/cmake -E cmake_link_script CMakeFiles/test_fib.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/gcc -O2 -g -DNDEBUG -fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer -fsanitize=undefined CMakeFiles/test_fib.dir/examples/fib.c.o CMakeFiles/test_fib.dir/gen/test_fib.c.o -o test_fib -Wl,-rpath,/tmp/guix-build-quickjs-0.9.0.drv-0/build libqjs.so.0.9.0 -ldl -lm
[ 90%] Linking C executable api-test
/gnu/store/2lxfijiqqljxdxr2ppqqrn5czkh4r1rq-cmake-minimal-3.24.2/bin/cmake -E cmake_link_script CMakeFiles/api-test.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/gcc -O2 -g -DNDEBUG -fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer -fsanitize=undefined "CMakeFiles/api-test.dir/api-test.c.o" -o api-test -Wl,-rpath,/tmp/guix-build-quickjs-0.9.0.drv-0/build libqjs.so.0.9.0 -ldl -lm
ld: CMakeFiles/test_fib.dir/gen/test_fib.c.o: in function `JS_NewCustomContext':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:54:(.text+0x20): undefined reference to `js_init_module_os'
ld: CMakeFiles/test_fib.dir/gen/test_fib.c.o: in function `main':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:66:(.text.startup+0x20): undefined reference to `js_std_set_worker_new_context_func'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:67:(.text.startup+0x28): undefined reference to `js_std_init_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:68:(.text.startup+0x2f): undefined reference to `js_module_loader'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:70:(.text.startup+0x52): undefined reference to `js_std_add_helpers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:71:(.text.startup+0x66): undefined reference to `js_std_eval_binary'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:72:(.text.startup+0x6e): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:76:(.text.startup+0x7d): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/gen/test_fib.c:74:(.text.startup+0xa2): undefined reference to `js_std_dump_error'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/test_fib.dir/build.make:117: test_fib] Error 1
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:393: CMakeFiles/test_fib.dir/all] Error 2
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
[ 90%] Built target api-test
[ 93%] Linking C executable qjsc
/gnu/store/2lxfijiqqljxdxr2ppqqrn5czkh4r1rq-cmake-minimal-3.24.2/bin/cmake -E cmake_link_script CMakeFiles/qjsc.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/gcc -O2 -g -DNDEBUG -fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer -fsanitize=undefined CMakeFiles/qjsc.dir/qjsc.c.o -o qjsc -Wl,-rpath,/tmp/guix-build-quickjs-0.9.0.drv-0/build:::::::::::::::::::: libqjs.so.0.9.0 -ldl -lm
ld: CMakeFiles/qjsc.dir/qjsc.c.o: in function `output_object_code':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjsc.c:175:(.text+0x850): undefined reference to `js_std_dump_error'
ld: CMakeFiles/qjsc.dir/qjsc.c.o: in function `jsc_module_loader':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjsc.c:247:(.text+0xd51): undefined reference to `js_load_file'
ld: CMakeFiles/qjsc.dir/qjsc.c.o: in function `compile_file':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjsc.c:285:(.text.startup+0x60b): undefined reference to `js_load_file'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjsc.c:301:(.text.startup+0xf60): undefined reference to `js_std_dump_error'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/qjsc.dir/build.make:101: qjsc] Error 1
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:133: CMakeFiles/qjsc.dir/all] Error 2
[ 96%] Linking C executable qjs
/gnu/store/2lxfijiqqljxdxr2ppqqrn5czkh4r1rq-cmake-minimal-3.24.2/bin/cmake -E cmake_link_script CMakeFiles/qjs_exe.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/gcc -O2 -g -DNDEBUG -Wl,--export-dynamic -rdynamic -fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer -fsanitize=undefined CMakeFiles/qjs_exe.dir/gen/repl.c.o CMakeFiles/qjs_exe.dir/gen/standalone.c.o CMakeFiles/qjs_exe.dir/qjs.c.o -o qjs -Wl,-rpath,/tmp/guix-build-quickjs-0.9.0.drv-0/build:::::::::::::::::::: libqjs.so.0.9.0 /gnu/store/9ypfhkz6f1bgjq95817m4989qfd68j84-mimalloc-2.1.2/lib/libmimalloc.so.2.1 -ldl -lm
ld: CMakeFiles/qjs_exe.dir/qjs.c.o: in function `load_standalone_module':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:90:(.text+0xae): undefined reference to `js_module_set_import_meta'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:95:(.text+0xd6): undefined reference to `js_std_await'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:100:(.text+0x12a): undefined reference to `js_std_dump_error'
ld: CMakeFiles/qjs_exe.dir/qjs.c.o: in function `eval_buf':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:126:(.text+0xc4d): undefined reference to `js_module_set_import_meta'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:133:(.text+0xc73): undefined reference to `js_std_await'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:138:(.text+0xca2): undefined reference to `js_std_dump_error'
ld: CMakeFiles/qjs_exe.dir/qjs.c.o: in function `eval_file':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:154:(.text+0xd3d): undefined reference to `js_load_file'
ld: CMakeFiles/qjs_exe.dir/qjs.c.o: in function `JS_NewCustomContext':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:233:(.text+0xfeb): undefined reference to `js_init_module_std'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:234:(.text+0xff8): undefined reference to `js_init_module_os'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:235:(.text+0x1005): undefined reference to `js_init_module_bjson'
ld: CMakeFiles/qjs_exe.dir/qjs.c.o: in function `main':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:614:(.text.startup+0x840): undefined reference to `js_std_set_worker_new_context_func'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:615:(.text.startup+0x848): undefined reference to `js_std_init_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:623:(.text.startup+0x863): undefined reference to `js_module_loader'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:626:(.text.startup+0x874): undefined reference to `js_std_promise_rejection_tracker'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:713:(.text.startup+0x8a4): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:713:(.text.startup+0xda2): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:629:(.text.startup+0x120f): undefined reference to `js_std_add_helpers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:743:(.text.startup+0x1361): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:690:(.text.startup+0x17ec): undefined reference to `js_std_eval_binary'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:697:(.text.startup+0x1817): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:713:(.text.startup+0x1907): undefined reference to `js_std_free_handlers'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:690:(.text.startup+0x1b23): undefined reference to `js_std_eval_binary'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:700:(.text.startup+0x1b2b): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/qjs.c:703:(.text.startup+0x1b3b): undefined reference to `js_std_dump_error'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/qjs_exe.dir/build.make:134: qjs] Error 1
make[2]: Leaving directory '/tmp/guix-build-quickjs-0.9.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:159: CMakeFiles/qjs_exe.dir/all] Error 2
[100%] Linking C executable run-test262
/gnu/store/2lxfijiqqljxdxr2ppqqrn5czkh4r1rq-cmake-minimal-3.24.2/bin/cmake -E cmake_link_script CMakeFiles/run-test262.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/gcc -O2 -g -DNDEBUG -fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer -fsanitize=undefined "CMakeFiles/run-test262.dir/run-test262.c.o" -o run-test262 -Wl,-rpath,/tmp/guix-build-quickjs-0.9.0.drv-0/build libqjs.so.0.9.0 -ldl -lm
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `JS_NewCustomContext':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1747:(.text+0x49): undefined reference to `js_init_module_std'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1748:(.text+0x56): undefined reference to `js_init_module_os'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1749:(.text+0x63): undefined reference to `js_init_module_bjson'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `js_module_loader_test':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1004:(.text+0x5bc): undefined reference to `js_load_file'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `agent_start':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:653:(.text+0x2a94): undefined reference to `js_std_dump_error'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:680:(.text+0x2b2c): undefined reference to `js_std_dump_error'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:646:(.text+0x2b4e): undefined reference to `js_std_dump_error'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `eval_buf':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1569:(.text+0xab9c): undefined reference to `js_std_loop'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1571:(.text+0xabaf): undefined reference to `js_std_dump_error'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `run_test_buf':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1768:(.text+0xd43f): undefined reference to `js_std_init_handlers'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `load_file':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:975:(.text+0xd5e5): undefined reference to `js_load_file'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `run_test_buf':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1807:(.text+0xd978): undefined reference to `js_std_free_handlers'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `JS_NewCustomContext':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1747:(.text+0xd9dc): undefined reference to `js_init_module_std'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1748:(.text+0xd9e9): undefined reference to `js_init_module_os'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:1749:(.text+0xd9f6): undefined reference to `js_init_module_bjson'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `load_file':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:975:(.text+0xdcbe): undefined reference to `js_load_file'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:975:(.text+0xed29): undefined reference to `js_load_file'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `run_test262_harness_test':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:2051:(.text+0xee35): undefined reference to `js_std_dump_error'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:2062:(.text+0xef64): undefined reference to `js_std_dump_error'
ld: /tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:2038:(.text+0xef84): undefined reference to `js_std_dump_error'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `main':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:2169:(.text.startup+0xb2): undefined reference to `js_std_set_worker_new_context_func'
ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `load_file':
/tmp/guix-build-quickjs-0.9.0.drv-0/source/run-test262.c:975:(.text.startup+0x4a9): undefined reference to `js_load_file'
collect2: error: ld returned 1 exit status |
Beta Was this translation helpful? Give feedback.
-
Sure.
I'd say a PR changing that would be welcome.
What type of build do you want to make? An end user build? |
Beta Was this translation helpful? Give feedback.
-
In my case, I am trying to write a Guix package expression so that |
Beta Was this translation helpful? Give feedback.
-
|
I tested The exit code is 0 regardless of the last line, since we have some expected test failures. I don't think the |
Beta Was this translation helpful? Give feedback.
-
|
What if the command was run directly, without using make? Does that make a difference? In my case, it says that status 256 was returned: error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "./run-test262" arguments: ("-m" "-c" "../source/test262.conf" "-c" "../source/test262-fast.conf" "-a") exit-status: 1 term-signal: #f stop-signal: #f>
phase `check' failed after 195.4 seconds
command "./run-test262" "-m" "-c" "../source/test262.conf" "-c" "../source/test262-fast.conf" "-a" failed with status 1
build process 10 exited with status 256
note: keeping build directory `/tmp/guix-build-quickjs-0.9.0.drv-49' |
Beta Was this translation helpful? Give feedback.
-
I suspect something may not be friendly with the paths. I'd suggest you run the test suite while on the quickjs root directory. |
Beta Was this translation helpful? Give feedback.
-
|
I think I figured it out - this may have to do with: Since now they're in the store, the new locations may have to be patched, which I'll know after substituting. However, one thing I've noticed is that there's no such file as |
Beta Was this translation helpful? Give feedback.
-
|
We have them in the main file, but having a separate file is supported. |
Beta Was this translation helpful? Give feedback.
-
|
I noticed you guys don't provide the test262.patch. The original fork shows that test262.patch was updated 2 weeks ago, but non262.js on the test262 site was updated last week. |
Beta Was this translation helpful? Give feedback.
-
|
I'd recommend running the suite on the same commit that is pinned here. |
Beta Was this translation helpful? Give feedback.
-
|
And re: test262.patch, it's not needed with quickjs-ng. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I am trying to package the next-gen version of QuickJS in Guix - which may replace the older, unmaintained version or exist as it's own new package - that, I'll have to ask the Guix maintainers.
Usually the packages build out of the box without any issues just by setting the build system (in this case,
cmake-build-system), but given how CTest wasn't used (hope that I am not wrong here), I wish to understand - as a package maintainer, what relevant tests should I run to ensure that the package expression ensures reproducible builds?Is
make testenough? Because in my system, excludingtest, all the other test rule in Makefile fails (test262,test262-check,test262-fastandtest262-update).Also relevant to the earlier point - is it okay if I do not pull submodules (
test262) when trying to build?Beta Was this translation helpful? Give feedback.
All reactions