Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending received "fromApp" messages messes repeating groups #608

Closed
mrefky opened this issue Dec 31, 2023 · 5 comments · Fixed by #636
Closed

sending received "fromApp" messages messes repeating groups #608

mrefky opened this issue Dec 31, 2023 · 5 comments · Fixed by #636

Comments

@mrefky
Copy link

mrefky commented Dec 31, 2023

If I resend the received fix message to the sender I get wrong message:

example code:

func (e *executor) FromApp(msg *quickfix.Message, sessionID quickfix.SessionID) (reject quickfix.MessageRejectError) {
quickfix.SendToTarget(msg,sessionID)
}

@mrefky mrefky changed the title sending recived fromApp messages messes repeating groups sending received fromApp messages messes repeating groups Dec 31, 2023
@mrefky mrefky changed the title sending received fromApp messages messes repeating groups sending received "fromApp" messages messes repeating groups Dec 31, 2023
@mrefky
Copy link
Author

mrefky commented Dec 31, 2023

Example from the logs:
Original send message:
2023/12/31 20:19:41.609553 8=FIX.4.4�9=216�35=D�34=2�347=UTF-8�52=20231231-20:19:41�49=01001�50=01001a�56=CASE�44=12�11=13976�1=10100400�21=1�386=1�336=NOPL�55=EGMFC001MM19�54=1�60=20231231-20:19:41�38=1�40=2�59=0�453=1�448=4501�447=D�452=28�354=6�355=Public�10=130�

Resent

2023/12/31 20:19:41.610119 8=FIX.4.4�9=220�35=D�34=2�49=CASE�50=01001a�52=20231231-20:19:41.609�56=01001�347=UTF-8�1=10100400�11=13976�21=1�38=1�40=2�44=12�54=1�55=EGMFC001MM19�59=0�60=20231231-20:19:41�336=NOPL�354=6�355=Public�386=1�447=D�448=4501�452=28�453=1�10=074�

@varunbpatil
Copy link

See also #568

@ackleymi
Copy link
Member

@mrefky I believe this is resolved in https://github.com/quickfixgo/quickfix/releases/tag/v0.9.1 please re-open issue if that is not the case.

@mrefky
Copy link
Author

mrefky commented Apr 25, 2024

Same thing using github.com/quickfixgo/quickfix v0.9.2

Field NoTradingSessions [386] must preceed Field TradingSessionID [336]

@mrefky
Copy link
Author

mrefky commented Apr 25, 2024

I dont know how to re-open this issue, please reopen and thanks for your note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants