Merge pull request #266 from cbusbey/check_latency

adds check latency configuration

Author: cbusbey

config/configuration.go

@@ -42,4 +42,5 @@ const (
 	ValidateFieldsOutOfOrder     string = "ValidateFieldsOutOfOrder"
 	ResendRequestChunkSize       string = "ResendRequestChunkSize"
 	EnableLastMsgSeqNumProcessed string = "EnableLastMsgSeqNumProcessed"
+	CheckLatency                 string = "CheckLatency"
 )

config/doc.go

@@ -185,6 +185,14 @@ If set to N, fields that are out of order (i.e. body fields in the header, or he
 
 Defaults to Y.
 
+CheckLatency
+
+If set to Y, messages must be received from the counterparty within a defined number of seconds. It is useful to turn this off if a system uses localtime for it's timestamps instead of GMT. Valid Values:
+ Y
+ N
+
+Defaults to Y.
+
 ReconnectInterval
 
 Time between reconnection attempts in seconds. Only used for initiators.    Value must be positive integer.

internal/session_settings.go

@@ -12,6 +12,7 @@ type SessionSettings struct {
 	InitiateLogon                bool
 	ResendRequestChunkSize       int
 	EnableLastMsgSeqNumProcessed bool
+	SkipCheckLatency             bool
 
 	//required on logon for FIX.T.1 messages
 	DefaultApplVerID string

session.go

@@ -576,6 +576,10 @@ func (s *session) checkCompID(msg Message) MessageRejectError {
 }
 
 func (s *session) checkSendingTime(msg Message) MessageRejectError {
+	if s.SkipCheckLatency {
+		return nil
+	}
+
 	if ok := msg.Header.Has(tagSendingTime); !ok {
 		return RequiredTagMissing(tagSendingTime)
 	}

session_factory.go

@@ -146,6 +146,15 @@ func (f sessionFactory) newSession(
 		}
 	}
 
+	if settings.HasSetting(config.CheckLatency) {
+		var doCheckLatency bool
+		if doCheckLatency, err = settings.BoolSetting(config.CheckLatency); err != nil {
+			return
+		}
+
+		s.SkipCheckLatency = !doCheckLatency
+	}
+
 	if settings.HasSetting(config.ResendRequestChunkSize) {
 		if s.ResendRequestChunkSize, err = settings.IntSetting(config.ResendRequestChunkSize); err != nil {
 			return

session_factory_test.go

@@ -47,6 +47,7 @@ func (s *SessionFactorySuite) TestDefaults() {
 	s.False(session.InitiateLogon)
 	s.Equal(0, session.ResendRequestChunkSize)
 	s.False(session.EnableLastMsgSeqNumProcessed)
+	s.False(session.SkipCheckLatency)
 }
 
 func (s *SessionFactorySuite) TestResetOnLogon() {
@@ -129,6 +130,23 @@ func (s *SessionFactorySuite) TestEnableLastMsgSeqNumProcessed() {
 	}
 }
 
+func (s *SessionFactorySuite) TestCheckLatency() {
+	var tests = []struct {
+		setting  string
+		expected bool
+	}{{"Y", false}, {"N", true}}
+
+	for _, test := range tests {
+		s.SetupTest()
+		s.SessionSettings.Set(config.CheckLatency, test.setting)
+		session, err := s.newSession(s.SessionID, s.MessageStoreFactory, s.SessionSettings, s.LogFactory, s.App)
+		s.Nil(err)
+		s.NotNil(session)
+
+		s.Equal(test.expected, session.SkipCheckLatency)
+	}
+}
+
 func (s *SessionFactorySuite) TestStartAndEndTime() {
 	s.SessionSettings.Set(config.StartTime, "12:00:00")
 	s.SessionSettings.Set(config.EndTime, "14:00:00")

session_test.go

@@ -169,6 +169,12 @@ func (s *SessionSuite) TestCheckSendingTime() {
 	msg.Header.SetField(tagSendingTime, FIXUTCTimestamp{Time: sendingTime})
 
 	s.Nil(s.session.checkSendingTime(msg), "sending time should be ok")
+
+	s.session.SkipCheckLatency = true
+	sendingTime = time.Now().Add(time.Duration(-200) * time.Second)
+	msg.Header.SetField(tagSendingTime, FIXUTCTimestamp{Time: sendingTime})
+	err = s.session.checkSendingTime(msg)
+	s.Require().Nil(err, "should skip latency check")
 }
 
 func (s *SessionSuite) TestCheckTargetTooLow() {