Skip to content

Noop message store implementation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

guidomedina
Copy link

Noop message store implementation.

@chrjohn chrjohn merged commit 2a77d99 into quickfix-j:master Dec 12, 2016
chrjohn added a commit that referenced this pull request Dec 12, 2016
…tion

Noop message store implementation
(cherry picked from commit 2a77d99)
@guidomedina guidomedina deleted the noop-message-store-implementation branch December 12, 2016 12:49
@guidomedina
Copy link
Author

guidomedina commented Dec 12, 2016

Would it be nice to replace MemoryStore by this one at some tests to make it faster?

@chrjohn
Copy link
Member

chrjohn commented Dec 12, 2016

If the tests don't rely on messages being resent (i.e. PersistMessages=N) then it might be an option.

@chrjohn
Copy link
Member

chrjohn commented Dec 12, 2016

@guidomedina The unit tests fail with this:

Tests run: 4, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.016 sec <<< FAILURE! - in quickfix.NoopStoreTest
testMessageStorageOutOfSequence(quickfix.NoopStoreTest)  Time elapsed: 0.015 sec  <<< ERROR!
java.lang.NullPointerException

testMessageStorageMessages(quickfix.NoopStoreTest)  Time elapsed: 0 sec  <<< ERROR!
java.lang.NullPointerException

testRefreshableMessageStore(quickfix.NoopStoreTest)  Time elapsed: 0 sec  <<< ERROR!
java.lang.NullPointerException


This is from the AbstractMessageStoreTest.

@chrjohn chrjohn modified the milestone: QFJ 1.6.3 Dec 12, 2016
@guidomedina
Copy link
Author

I think I know what it is, no default constructor, adding it and testing.

@guidomedina
Copy link
Author

Failed again, I can't figure out what's the trick, do I need to declare exceptions?

Tests in error: 
  NoopStoreTest>AbstractMessageStoreTest.testMessageStorageMessages:107 » NullPointer
  NoopStoreTest>AbstractMessageStoreTest.testMessageStorageOutOfSequence:124 » NullPointer
  NoopStoreTest>AbstractMessageStoreTest.testRefreshableMessageStore:160 » NullPointer

@chrjohn
Copy link
Member

chrjohn commented Dec 12, 2016

I'll have a look

@guidomedina
Copy link
Author

I look these tests and I think we should delete NoopStoreTest as these tests expect messages to be stored where NoopStore is all the oppossite, sending PR.

@chrjohn
Copy link
Member

chrjohn commented Dec 12, 2016

The session that is tried to lookup is NULL in the NoopStore.refresh() method. But I don't know why this works for the other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants