Pass SessionID to MemoryStore constructor from MemoryStoreFactory #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the TravisCI build timed out rather than failed |
chrjohn
pushed a commit
that referenced
this pull request
Jan 25, 2018
* pass SessionID to MemoryStore on construction * Update MemoryStore.java * fix for NPE on session lookup which causes test failures (cherry picked from commit 3cf3964)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the code the only change in behavior based on this will be that the "memory store does not support refresh!" error generated if #refresh is called will be logged at the session level.
The upside is it will make debugging a lot easier.