QFJ-944 Misleading error message when receiving Logon with tag RawData(96) without RawDataLength(95) (#181)

chrjohn · chrjohn · commit 4e5fc8c089c5 · 2018-03-15T09:36:57.000+01:00
- improved error message (cherry picked from commit c14b77e)
diff --git a/quickfixj-core/src/main/java/quickfix/Message.java b/quickfixj-core/src/main/java/quickfix/Message.java
@@ -819,7 +819,7 @@ private StringField extractField(DataDictionary dataDictionary, FieldMap fields)
             try {
                 fieldLength = fields.getInt(lengthField);
             } catch (final FieldNotFound e) {
-                throw new InvalidMessage("Tag " + e.field + " not found in " + messageData);
+                throw new InvalidMessage("Did not find length field " + e.field + " required to parse data field " + tag + " in " + messageData);
             }
 
             // since length is in bytes but data is a string, and it may also contain an SOH,

Original file line number	Diff line number	Diff line change
`@@ -819,7 +819,7 @@ private StringField extractField(DataDictionary dataDictionary, FieldMap fields)`
`819`	`819`	`try {`
`820`	`820`	`fieldLength = fields.getInt(lengthField);`
`821`	`821`	`} catch (final FieldNotFound e) {`
`822`		`- throw new InvalidMessage("Tag " + e.field + " not found in " + messageData);`
	`822`	`+ throw new InvalidMessage("Did not find length field " + e.field + " required to parse data field " + tag + " in " + messageData);`
`823`	`823`	`}`
`824`	`824`
`825`	`825`	`// since length is in bytes but data is a string, and it may also contain an SOH,`