You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should simplify installing the tools dependencies. The Makefile tools target and its sub-targets works, but it is a bit magic, requiring even people with general makefile knowledge to lookup the documentation to understand what's going on.
Move the tools.go file to internal/tools package.
Augment the tools.go file with lines like this: //go:generate go install google.golang.org/protobuf/cmd/protoc-gen-go
The Makefile would instead do this:
tools: internal/tools/*.go
go generate --tags tools ./internal/tools
Or we could wait for golang/go issue #48429, which should obviate the need for a separate tools.go file and Makefile targets, since it would be supported by the go command itself.
The text was updated successfully, but these errors were encountered:
We should simplify installing the tools dependencies. The Makefile tools target and its sub-targets works, but it is a bit magic, requiring even people with general makefile knowledge to lookup the documentation to understand what's going on.
tools.go
file tointernal/tools
package.tools.go
file with lines like this://go:generate go install google.golang.org/protobuf/cmd/protoc-gen-go
The Makefile would instead do this:
This is inspired by protopatch.
Or we could wait for golang/go issue #48429, which should obviate the need for a separate
tools.go
file and Makefile targets, since it would be supported by the go command itself.The text was updated successfully, but these errors were encountered: