Add custom op examples and documentation #638
Conversation
quic-rishinr
requested review from
ochougul,
quic-amitraj and
quic-hemagnih
as code owners
examples/onboarding_guide/customop/CustomGELU/src/customgelu_aic.cpp
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,27 @@ | |||
| --- | |||
There was a problem hiding this comment.
should we add the binary to folder? let user generate based on the readme?
quic-hemagnih
left a comment
quic-hemagnih
left a comment
There was a problem hiding this comment.
I think we should remove the lib.so file. Let customer generate their own lib.so file.
examples/onboarding_guide/customop/CustomGELU/src/customgelu_functions.cpp
Show resolved
Hide resolved
| @@ -0,0 +1,23 @@ | |||
| //----------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Can you please double check the copyrights, I could see the following copyrights used in CPP files.
Can you please check this once from Jeff.
//-----------------------------------------------------------------------------
//
// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. All rights reserved.
// Confidential and Proprietary - Qualcomm Technologies, Inc. and/or its subsidiaries.
//
//-----------------------------------------------------------------------------
Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
quic-rishinr
force-pushed
the
custom_op
branch
from
03d2735 to
90c4b1d
Compare
3 participants
Added step by step instructions for adding custom op in Qeff