[QEff.Finetuning] Adding optimizer registry and its test cases #634
+123
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
tchawada
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Contributor
Add some description to PR. |
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-meetkuma
requested changes
Dec 1, 2025
Contributor
quic-meetkuma
left a comment
quic-meetkuma
left a comment
There was a problem hiding this comment.
Overall good clean code. Needs little bit of polishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Script for Registering and Retrieving Optimizer Classes
The script includes two primary functions:
register_optimizer()
This function is responsible for registering an optimizer.
get_optimizer()
Returns the optimizer class and kwargs.
Additionally, there is a test_optimizer.py script that validates the functionality of the optimizer registration and retrieval process.