wip

Author: MHajoha

classes/constants.php

@@ -36,6 +36,8 @@ class constants {
     public const QT_VAR_SCORING_STATE = '_scoringstate';
     /** @var string */
     public const QT_VAR_RESPONSE = 'qpy_response';
+        /** @var string */
+    public const QT_VAR_DRAFT_AREAS = 'qpy_draft_areas';
 
     /** @var string */
     public const QPY_OPTIONS_URL_PATTERN = ';qpy://options/(?P<fileref>[a-zA-Z0-9\-_=]{1,64});';

classes/local/attempt_ui/question_ui_renderer.php

@@ -17,6 +17,7 @@
 namespace qtype_questionpy\local\attempt_ui;
 
 use coding_exception;
+use context;
 use core\di;
 use DOMAttr;
 use DOMDocument;
@@ -26,6 +27,7 @@
 use DOMProcessingInstruction;
 use DOMText;
 use DOMXPath;
+use form_filemanager;
 use moodle_exception;
 use qtype_questionpy\constants;
 use qtype_questionpy\local\files\qpy_url_resolver;
@@ -49,6 +51,9 @@ class question_ui_renderer {
     /** @var string $html resulting rendered html */
     public string $html;
 
+    /** @var array<string, int> Mapping of input names to draft item ids.  */
+    public array $draftareas = [];
+
     /** @var invalid_option_warning[] $warnings warnings emitted during rendering */
     public array $warnings;
 
@@ -152,10 +157,45 @@ public static function render(string $xml, array $placeholders, question_display
 
         $warnings = $renderer->check_for_and_preserve_unknown_options($availableoptions, $attempt);
         $renderer->html = $renderer->xml->saveHTML();
+        $renderer->html .= $renderer->render_file_manager($attempt, $question);
         $renderer->warnings = $warnings;
         return $renderer;
     }
 
+    /**
+     * @throws moodle_exception
+     * @throws coding_exception
+     */
+    private function render_file_manager(question_attempt $attempt, qtype_questionpy_question $question): string {
+        global $CFG, $PAGE;
+        require_once($CFG->libdir . '/form/filemanager.php');
+
+        $context = context::instance_by_id($question->contextid);
+
+        $draftitemid = $attempt->prepare_response_files_draft_itemid('banana', $context->id);
+
+        // Adding a hidden input here that holds the draftarea would require us to separate it from the "proper" form data later on.
+        // Instead, we save the draft area for.
+        $this->draftareas['myupload'] = $draftitemid;
+
+        $id = uniqid();
+
+        $fm = new form_filemanager((object)[
+            'itemid' => $draftitemid,
+            'subdirs' => false,
+            'context' => $context,
+            'maxfiles' => 1,
+            'maxbytes' => 1024 * 1024,
+            'areamaxbytes' => 2 * 1024 * 1024,
+            'clientid' => $id,
+        ]);
+
+        $filesrenderer = $PAGE->get_renderer('core', 'files');
+        $html = $filesrenderer->render($fm);
+
+        return $html;
+    }
+
     /**
      * Hides elements marked with `qpy:feedback` if the type of feedback is disabled in {@see question_display_options}
      * or if it does not exist.

question.php

@@ -235,6 +235,7 @@ private function get_behaviour(): qbehaviour_questionpy {
     public function get_expected_data(): array|string {
         return [
             constants::QT_VAR_RESPONSE => PARAM_RAW_TRIMMED,
+            constants::QT_VAR_DRAFT_AREAS => PARAM_RAW_TRIMMED,
         ];
     }
 

renderer.php

@@ -83,10 +83,16 @@ public function formulation_and_controls(question_attempt $qa, question_display_
         }
 
         try {
+            /** @var array<string, int>|null $uploaddraftareas */
+            $uploaddraftareas = null;
+
             $questiondivid = $qa->get_outer_question_div_unique_id();
             $qpyresponseid = $questiondivid . '-qpy-response';
-            $formulationcb = function (qtype_questionpy_renderer $renderer) use ($qa, $question, $options, $qpyresponseid) {
-                return $renderer->formulation_controls_feedback_in_iframe($qa, $question->ui, $options, $qpyresponseid);
+            $formulationcb = function (qtype_questionpy_renderer $renderer) use ($qa, $question, $options, $qpyresponseid, &$uploaddraftareas) {
+                $quirenderer = question_ui_renderer::render($question->ui->formulation, $question->ui->placeholders, $options, $qa);
+                $uploaddraftareas = $quirenderer->draftareas;
+
+                return $renderer->formulation_controls_feedback_in_iframe($qa, $question->ui, $quirenderer, $options, $qpyresponseid);
             };
             $iframesrc = $this->get_iframe_document($options->context, $question, $formulationcb);
 
@@ -125,6 +131,17 @@ public function formulation_and_controls(question_attempt $qa, question_display_
                 <iframe id="{$iframeid}" srcdoc="{$iframesrc}"></iframe>
             EOA;
 
+            if ($uploaddraftareas === null) {
+                throw new coding_exception('$uploaddraftareas was not set');
+            }
+            if (count($uploaddraftareas) > 0) {
+                $result .= html_writer::empty_tag('input', [
+                    'type' => 'hidden',
+                    'name' => $qa->get_field_prefix() . constants::QT_VAR_DRAFT_AREAS,
+                    'value' => json_encode($uploaddraftareas, JSON_FORCE_OBJECT),
+                ]);
+            }
+
             return $result;
         } catch (Throwable $t) {
             global $USER;
@@ -220,13 +237,11 @@ protected function get_iframe_document(context $context, qtype_questionpy_questi
      * @throws moodle_exception
      */
     protected function formulation_controls_feedback_in_iframe(
-        question_attempt $qa, attempt_ui $ui,
+        question_attempt $qa, attempt_ui $ui, question_ui_renderer $renderer,
         question_display_options $options, string $qpyresponseid
     ): string {
         global $CFG;
 
-        $renderer = question_ui_renderer::render($ui->formulation, $ui->placeholders, $options, $qa);
-
         $warningshtml = '';
         if ($renderer->warnings) {
             global $USER;

styles.css

@@ -30,6 +30,9 @@
     padding: 0;
     width: 100%;
     height: 0;
+    /* TODO: Only set the min-height when the question uses a file picker and figure out the correct height.
+             (The current value is arbitrary.) */
+    min-height: 700px;
     display: block; /* Remove space that is reserved below inline elements for descender characters (y, q, g). */
 }