feat: delete options files when question is deleted

Author: MHajoha

classes/local/files/options_file_service.php

@@ -85,6 +85,18 @@ public function save_draft_area_files(int $contextid, int $questionid, int $user
         }
     }
 
+    /**
+     * Deletes all files in the permanent file area of the given question.
+     *
+     * @param int $contextid
+     * @param int $questionid
+     * @return void
+     */
+    public function delete_all_saved_files_belonging_to_question(int $contextid, int $questionid): void {
+        $fs = get_file_storage();
+        $fs->delete_area_files($contextid, 'qtype_questionpy', self::FILEAREA_UPLOADS, $questionid);
+    }
+
     /**
      * Populates the given draft area with files listed in `$filemetas` and stored in the permanent question file area.
      *

classes/question_service.php

@@ -224,11 +224,14 @@ public function upsert_question(object $question): void {
      * Deletes all QuestionPy-specific data for the given question.
      *
      * @param int $questionid
+     * @param int $contextid The context this question belongs to.
      * @throws dml_exception
      */
-    public static function delete_question(int $questionid) {
+    public function delete_question(int $questionid, int $contextid) {
         global $DB;
         $DB->delete_records(self::QUESTION_TABLE, ['questionid' => $questionid]);
         // TODO: Also delete packages when they are no longer used by any question.
+
+        $this->ofs->delete_all_saved_files_belonging_to_question($contextid, $questionid);
     }
 }

questiontype.php

@@ -87,8 +87,8 @@ public function is_question_manual_graded($question, $otherquestionsinuse) {
      * @param int $contextid the context this question belongs to.
      * @throws moodle_exception
      */
-    public function delete_question($questionid, $contextid) {
-        question_service::delete_question($questionid);
+    public function delete_question($questionid, $contextid): void {
+        $this->questionservice->delete_question($questionid, $contextid);
         parent::delete_question($questionid, $contextid);
     }
 

tests/question_service_test.php

@@ -431,10 +431,10 @@ public function test_delete_question(): void {
         $pvi->upsert();
         $this->setup_question($pvi->versions[0]->hash);
 
-        global $DB;
+        global $DB, $PAGE;
         $this->assertEquals(1, $DB->count_records('qtype_questionpy'));
 
-        question_service::delete_question(1);
+        $this->questionservice->delete_question(1, $PAGE->context->id);
 
         $this->assertEquals(0, $DB->count_records('qtype_questionpy'));
     }