Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what do we do about Int32 overflows? #2

Closed
ExpandingMan opened this issue Mar 16, 2018 · 1 comment
Closed

what do we do about Int32 overflows? #2

ExpandingMan opened this issue Mar 16, 2018 · 1 comment

Comments

@ExpandingMan
Copy link

This is something I'm still worried about, recall this issue on Feather.jl. No, I haven't had any communication with the Arrow community yet.

Confusingly Feather seems to violate the Arrow format in several places. From what I could gather, it seems almost like Feather files really do have arrays with length greater than typemax(Int32), but they use the ability of the C++ arrow package to pull data in chunks to get around that somehow.

Note that I have "silently" changed all of the array length values in Arrow.jl to be Int rather than Int32. This would make it very easy for us to cheat in some cases, but of course offsets are still Int32.

So I don't know. This is a major concern, but I haven't really had time to reach out to the arrow community on this yet.

See related issues here and here.

@davidanthoff
Copy link
Member

I've just pinged Wes about this on the Arrow.jl issue, maybe he can chime in and help us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants