Skip to content

Commit 2a5d008

Browse files
committed
minor code quality improvements
1 parent d3dfbe4 commit 2a5d008

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

src/networking/connection.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ def on_disconnect(self):
214214
# Terminate the server threads if there is one
215215
if self.server:
216216
self.server.stop()
217-
# Forcibly destroy the server's socket
218217
self.server.destroy_socket()
219218

220219
def initialize_connection(self):

src/networking/packet_handler/serverbound/login_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def setup(self):
5555
unknown_packet = self.read_packet_from_stream().packet_buffer
5656

5757
print("Unknown packet", unknown_packet, flush=True)
58-
except:
58+
except (EOFError, ValueError):
5959
# Fail to join
6060
return False
6161

src/networking/packets/clientbound/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,6 @@ class ChunkData(Packet):
7676
def read_fields(self, packet_buffer):
7777
self.ChunkX = Integer.read(packet_buffer)
7878
self.ChunkZ = Integer.read(packet_buffer)
79-
self.GroundUpContinuous = Boolean.read(packet_buffer)
80-
self.PrimaryBitMask = VarInt.read(packet_buffer)
81-
self.Data = VarIntPrefixedByteArray.read(packet_buffer)
82-
83-
self.NumBlockEnts = VarInt.read(packet_buffer)
84-
8579

8680

8781
class UnloadChunk(Packet):

0 commit comments

Comments
 (0)