Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managing-google-analytics.md #8490

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Update managing-google-analytics.md #8490

merged 2 commits into from
Feb 17, 2021

Conversation

NdagiStanley
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Contributor Author

@NdagiStanley NdagiStanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: error Unnecessarily quoted property 'screenPath' found quote-props

Fixes `error  Unnecessarily quoted property 'screenPath' found  quote-props`
@rstoenescu rstoenescu merged commit 60724af into quasarframework:dev Feb 17, 2021
@rstoenescu
Copy link
Member

Thanks!

rstoenescu pushed a commit that referenced this pull request Feb 17, 2021
* Update managing-google-analytics.md

* Apply suggestions from code review

Fixes `error  Unnecessarily quoted property 'screenPath' found  quote-props`
@NdagiStanley
Copy link
Contributor Author

You're welcome

@NdagiStanley NdagiStanley deleted the patch-1 branch February 19, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants