-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update managing-google-analytics.md #8490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NdagiStanley
commented
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes: error Unnecessarily quoted property 'screenPath' found quote-props
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
docs/src/pages/quasar-cli/developing-capacitor-apps/managing-google-analytics.md
Outdated
Show resolved
Hide resolved
Fixes `error Unnecessarily quoted property 'screenPath' found quote-props`
Thanks! |
rstoenescu
pushed a commit
that referenced
this pull request
Feb 17, 2021
* Update managing-google-analytics.md * Apply suggestions from code review Fixes `error Unnecessarily quoted property 'screenPath' found quote-props`
rstoenescu
added a commit
that referenced
this pull request
Feb 17, 2021
rstoenescu
added a commit
that referenced
this pull request
Feb 17, 2021
You're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: