Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Default Loading Indicator #13533

Open
yusufkandemir opened this issue May 25, 2022 Discussed in #13471 · 1 comment
Open

Configurable Default Loading Indicator #13533

yusufkandemir opened this issue May 25, 2022 Discussed in #13471 · 1 comment

Comments

@yusufkandemir
Copy link
Member

yusufkandemir commented May 25, 2022

Discussed in #13471

Originally posted by @jensgerntholtz May 19, 2022

The Problem

The Component Library provided by Quasar has a pattern of including a Loading Indicator within numerous components. The Loading Indicator is displayed when the component is in a loading state. This state is set via a boolean provided by the loading prop whenever the component is used.

The Loading Indicator / Spinner component that is used throughout is QSpinner. The only manner in which to set a derivative Spinner component or Custom spinner component is to do this via the template.
eg.

non-components also utilize QSpinner and have no options to configure the Loading Indicator

However, plugins such as

  • Notify, Loading have a configurable default option (and options on per-occurrence basis) settable within "QuasarConfOptions" quasar.conf.js > framework > config
{
  framework: {
    config: {
      notify: {
        spinner: 'QSpinnerFacebook';
      }
      loading: {
        spinner: 'QSpinnerFacebook';
      }
    }
  }
}

Yet

  • Dialog.js aka DialogPlugin.js has no configurable default Loading Indicator via the quasar.conf.js it only lets you set the spinner on a per-occurrence basis?
$q.dialog({
   progress: {
     spinner: QSpinnerGears
   }
})

Proposal:

To have a configurable default Loading Indicator / Spinner component in quasar.conf.js so that if you have a derivative Spinner preference or a custom Spinner you do not have to extend the js or are forced to use the Vue template (where applicable) for each of the mentioned components, plugins, and functions in order to replace QSpinnner.

@jagoncalves14
Copy link

I second this.

I'm working on a project where the designed loading spinner is always QSpinnerOval instead of the default one.
It would be great if there was a way to replace that Spinner across all components (e.g. QInput, QSelect, QButton, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants