Skip to content

Commit ff54007

Browse files
authored
fix(Ripple): don't trigger duplicate early ripple on mobiles #13596 (#13728)
1 parent cb53eb8 commit ff54007

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

ui/src/directives/Ripple.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,7 @@ export default createDirective(__QUASAR_SSR_SERVER__
8787
if (
8888
ctx.enabled === true
8989
&& evt.qSkipRipple !== true
90-
&& (
91-
ctx.modifiers.early === true
92-
? [ 'mousedown', 'touchstart' ].includes(evt.type) === true
93-
: evt.type === 'click'
94-
)
90+
&& evt.type === (ctx.modifiers.early === true ? 'pointerdown' : 'click')
9591
) {
9692
showRipple(evt, el, ctx, evt.qKeyEvent === true)
9793
}
@@ -114,8 +110,7 @@ export default createDirective(__QUASAR_SSR_SERVER__
114110
el.__qripple = ctx
115111

116112
addEvt(ctx, 'main', [
117-
[ el, 'mousedown', 'start', 'passive' ],
118-
[ el, 'touchstart', 'start', 'passive' ],
113+
[ el, 'pointerdown', 'start', 'passive' ],
119114
[ el, 'click', 'start', 'passive' ],
120115
[ el, 'keydown', 'keystart', 'passive' ],
121116
[ el, 'keyup', 'keystart', 'passive' ]

0 commit comments

Comments
 (0)