feat(app-webpack): linting

Author: rstoenescu

app-vite/lib/cmd/help.js

@@ -8,7 +8,7 @@ console.log(
 if (process.env.QUASAR_CLI_VERSION) {
   console.log('  Running @quasar/cli v' + process.env.QUASAR_CLI_VERSION)
 }
-console.log('  Running @quasar/app-vite v' + require('../package.json').version)
+console.log('  Running @quasar/app-vite v' + require('../../package.json').version)
 
 console.log(`
   Example usage

app-vite/templates/entry/app.js

@@ -16,12 +16,10 @@ import vueDevtools from '@vue/devtools'
 <% } %>
 
 import { Quasar } from 'quasar'
+import { markRaw } from 'vue'
 import <%= metaConf.needsAppMountHook === true ? 'AppComponent' : 'RootComponent' %> from 'app/<%= sourceFiles.rootComponent %>'
 
-<% if (store) { %>
-import createStore from 'app/<%= sourceFiles.store %>'
-import { markRaw } from 'vue'
-<% } %>
+<% if (store) { %>import createStore from 'app/<%= sourceFiles.store %>'<% } %>
 import createRouter from 'app/<%= sourceFiles.router %>'
 
 <% if (ctx.mode.capacitor) { %>

app-webpack/.eslintignore

@@ -0,0 +1 @@
+templates/

app-webpack/.eslintrc.js

@@ -0,0 +1,24 @@
+module.exports = {
+  root: true,
+
+  parserOptions: {
+    ecmaVersion: 2022,
+  },
+
+  env: {
+    node: true,
+  },
+
+  extends: [
+    'eslint:recommended',
+    'plugin:node/recommended'
+  ],
+
+  rules: {
+    'no-empty': 'off',
+    'no-useless-escape': 'off',
+    'no-unused-vars': ['error', { ignoreRestSiblings: true, argsIgnorePattern: '^_' }],
+
+    'no-process-exit': 'off',
+  }
+}

app-webpack/bin/quasar

@@ -61,7 +61,7 @@ if (cmd) {
       const exit = process.exit
       process.exit = (code, reason) => {
         if (reason === 'ext-missing') {
-          require('./quasar-help')
+          require('../lib/cmd/help')
           exit(0)
         }
         else {
@@ -77,4 +77,4 @@ else {
   cmd = 'help'
 }
 
-require(`./quasar-${cmd}`)
+require(`../lib/cmd/${cmd}`)

app-webpack/bin/quasar-build renamed to app-webpack/lib/cmd/build.js

@@ -1,4 +1,3 @@
-#!/usr/bin/env node
 
 if (process.env.NODE_ENV === void 0) {
   process.env.NODE_ENV = 'production'
@@ -90,25 +89,25 @@ if (argv.help) {
   process.exit(0)
 }
 
-const ensureArgv = require('../lib/helpers/ensure-argv')
+const ensureArgv = require('../helpers/ensure-argv')
 ensureArgv(argv, 'build')
 
-const ensureVueDeps = require('../lib/helpers/ensure-vue-deps')
+const ensureVueDeps = require('../helpers/ensure-vue-deps')
 ensureVueDeps()
 
 console.log(
   require('fs').readFileSync(
-    require('path').join(__dirname, '../assets/logo.art'),
+    require('path').join(__dirname, '../../assets/logo.art'),
     'utf8'
   )
 )
 
-const banner = require('../lib/helpers/banner')
+const banner = require('../helpers/banner')
 banner(argv, 'build')
 
-const { log, fatal } = require('../lib/helpers/logger')
-const { printWebpackErrors } = require('../lib/helpers/print-webpack-issue')
-const { webpackNames, splitWebpackConfig } = require('../lib/webpack/symbols')
+const { log, fatal } = require('../helpers/logger')
+const { printWebpackErrors } = require('../helpers/print-webpack-issue')
+const { webpackNames, splitWebpackConfig } = require('../webpack/symbols')
 
 const path = require('path')
 const webpack = require('webpack')
@@ -132,10 +131,10 @@ function finalizeBuild (mode, ctx, quasarConfFile) {
   let Runner
 
   if (['cordova', 'capacitor'].includes(mode)) {
-    Runner = require('../lib/' + mode)
+    Runner = require('../' + mode)
   }
   else if (argv['skip-pkg'] !== true && mode === 'electron') {
-    Runner = require('../lib/electron')
+    Runner = require('../electron')
   }
 
   if (Runner !== void 0) {
@@ -148,16 +147,16 @@ function finalizeBuild (mode, ctx, quasarConfFile) {
 
 async function build () {
   if (argv.mode !== 'spa') {
-    const installMissing = require('../lib/mode/install-missing')
+    const installMissing = require('../mode/install-missing')
     await installMissing(argv.mode, argv.target)
   }
 
-  const QuasarConfFile = require('../lib/quasar-conf-file')
-  const Generator = require('../lib/generator')
-  const artifacts = require('../lib/artifacts')
-  const getQuasarCtx = require('../lib/helpers/get-quasar-ctx')
-  const extensionRunner = require('../lib/app-extension/extensions-runner')
-  const regenerateTypesFeatureFlags = require('../lib/helpers/types-feature-flags')
+  const QuasarConfFile = require('../quasar-conf-file')
+  const Generator = require('../generator')
+  const artifacts = require('../artifacts')
+  const getQuasarCtx = require('../helpers/get-quasar-ctx')
+  const extensionRunner = require('../app-extension/extensions-runner')
+  const regenerateTypesFeatureFlags = require('../helpers/types-feature-flags')
 
   const ctx = getQuasarCtx({
     mode: argv.mode,
@@ -210,7 +209,7 @@ async function build () {
   // can only know it after parsing the quasar.config.js file
   if (quasarConfFile.ctx.mode.pwa === true) {
     // need to build the custom service worker before renderer
-    Runner = require('../lib/pwa')
+    const Runner = require('../pwa')
     Runner.init(ctx)
     await Runner.build(quasarConfFile, argv)
   }
@@ -242,7 +241,7 @@ async function build () {
       fatal(`for "${webpackData.name[index]}" with ${summary}. Please check the log above.`, 'COMPILATION FAILED')
     })
 
-    const printWebpackStats = require('../lib/helpers/print-webpack-stats')
+    const printWebpackStats = require('../helpers/print-webpack-stats')
 
     console.log()
     statsArray.forEach((stats, index) => {

app-webpack/bin/quasar-clean renamed to app-webpack/lib/cmd/clean.js

@@ -1,8 +1,7 @@
-#!/usr/bin/env node
 
 const parseArgs = require('minimist')
 
-const { log } = require('../lib/helpers/logger')
+const { log } = require('../helpers/logger')
 
 const argv = parseArgs(process.argv.slice(2), {
   alias: {
@@ -23,7 +22,7 @@ if (argv.help) {
   process.exit(0)
 }
 
-const Artifacts = require('../lib/artifacts')
+const Artifacts = require('../artifacts')
 Artifacts.cleanAll()
 
 console.log()

app-webpack/bin/quasar-describe renamed to app-webpack/lib/cmd/describe.js

@@ -1,10 +1,9 @@
-#!/usr/bin/env node
 
 const parseArgs = require('minimist')
 const chalk = require('chalk')
 
-const getApi = require('../lib/helpers/get-api')
-const { fatal } = require('../lib/helpers/logger')
+const getApi = require('../helpers/get-api')
+const { fatal } = require('../helpers/logger')
 
 const partArgs = {
   p: 'props',
@@ -251,7 +250,7 @@ function printSlots ({ slots }) {
   }
 }
 
-function printEvents ({ events, behavior = {} }) {
+function printEvents ({ events }) {
   const keys = Object.keys(events || {})
 
   console.log('\n ' + chalk.underline('Events'))
@@ -466,7 +465,7 @@ async function run () {
 
     if (apiParts.docs) {
       if (api.meta && api.meta.docsUrl) {
-        const openBrowser = require('../lib/helpers/open-browser')
+        const openBrowser = require('../helpers/open-browser')
         openBrowser({ url: api.meta.docsUrl, wait: false })
       }
       else {
@@ -495,11 +494,10 @@ async function run () {
 }
 
 function listElements () {
-  const getDevlandFile = require('../lib/helpers/get-devland-file')
+  const getDevlandFile = require('../helpers/get-devland-file')
   let api = getDevlandFile('quasar/dist/transforms/api-list.json')
 
   if (api === void 0) {
-    console.log(e)
     fatal(` Could not retrieve list...`)
   }
 

app-webpack/bin/quasar-dev renamed to app-webpack/lib/cmd/dev.js

@@ -1,12 +1,11 @@
-#!/usr/bin/env node
 
 if (process.env.NODE_ENV === void 0) {
   process.env.NODE_ENV = 'development'
 }
 
 const parseArgs = require('minimist')
 
-const { log, warn, fatal } = require('../lib/helpers/logger')
+const { log, warn, fatal } = require('../helpers/logger')
 
 const argv = parseArgs(process.argv.slice(2), {
   alias: {
@@ -77,23 +76,23 @@ if (argv.help) {
   process.exit(0)
 }
 
-const ensureArgv = require('../lib/helpers/ensure-argv')
+const ensureArgv = require('../helpers/ensure-argv')
 ensureArgv(argv, 'dev')
 
-const ensureVueDeps = require('../lib/helpers/ensure-vue-deps')
+const ensureVueDeps = require('../helpers/ensure-vue-deps')
 ensureVueDeps()
 
 console.log(
   require('fs').readFileSync(
-    require('path').join(__dirname, '../assets/logo.art'),
+    require('path').join(__dirname, '../../assets/logo.art'),
     'utf8'
   )
 )
 
-const banner = require('../lib/helpers/banner')
+const banner = require('../helpers/banner')
 banner(argv, 'dev')
 
-const findPort = require('../lib/helpers/net').findClosestOpenPort
+const findPort = require('../helpers/net').findClosestOpenPort
 
 async function parseAddress ({ host, port }) {
   if (this.chosenHost) {
@@ -103,7 +102,7 @@ async function parseAddress ({ host, port }) {
     ['cordova', 'capacitor'].includes(argv.mode) &&
     (!host || ['0.0.0.0', 'localhost', '127.0.0.1', '::1'].includes(host.toLowerCase()))
   ) {
-    const getExternalIP = require('../lib/helpers/get-external-ip')
+    const getExternalIP = require('../helpers/get-external-ip')
     host = await getExternalIP()
     this.chosenHost = host
   }
@@ -146,8 +145,8 @@ async function parseAddress ({ host, port }) {
 }
 
 function startVueDevtools () {
-  const { spawn } = require('../lib/helpers/spawn')
-  const getPackagePath = require('../lib/helpers/get-package-path')
+  const { spawn } = require('../helpers/spawn')
+  const getPackagePath = require('../helpers/get-package-path')
 
   let vueDevtoolsBin = getPackagePath('@vue/devtools/bin.js')
 
@@ -161,7 +160,7 @@ function startVueDevtools () {
     return
   }
 
-  const nodePackager = require('../lib/helpers/node-packager')
+  const nodePackager = require('../helpers/node-packager')
 
   nodePackager.installPackage('@vue/devtools', { isDev: true })
 
@@ -176,18 +175,18 @@ function startVueDevtools () {
 
 async function goLive () {
   if (argv.mode !== 'spa') {
-    const installMissing = require('../lib/mode/install-missing')
+    const installMissing = require('../mode/install-missing')
     await installMissing(argv.mode, argv.target)
   }
 
   const DevServer = argv.mode === 'ssr'
-    ? require('../lib/dev-server-ssr')
-    : require('../lib/dev-server-regular')
-  const QuasarConfFile = require('../lib/quasar-conf-file')
-  const Generator = require('../lib/generator')
-  const getQuasarCtx = require('../lib/helpers/get-quasar-ctx')
-  const extensionRunner = require('../lib/app-extension/extensions-runner')
-  const regenerateTypesFeatureFlags = require('../lib/helpers/types-feature-flags')
+    ? require('../dev-server-ssr')
+    : require('../dev-server-regular')
+  const QuasarConfFile = require('../quasar-conf-file')
+  const Generator = require('../generator')
+  const getQuasarCtx = require('../helpers/get-quasar-ctx')
+  const extensionRunner = require('../app-extension/extensions-runner')
+  const regenerateTypesFeatureFlags = require('../helpers/types-feature-flags')
 
   const ctx = getQuasarCtx({
     mode: argv.mode,
@@ -246,7 +245,7 @@ async function goLive () {
   let runMode
 
   if (['cordova', 'capacitor', 'electron', 'bex', 'pwa', 'ssr'].includes(argv.mode)) {
-    const ModeRunner = require('../lib/' + (argv.mode === 'ssr' ? 'pwa' : argv.mode))
+    const ModeRunner = require('../' + (argv.mode === 'ssr' ? 'pwa' : argv.mode))
     ModeRunner.init(ctx)
     runMode = () => ModeRunner.run(quasarConfFile, argv)
   }

app-webpack/bin/quasar-ext renamed to app-webpack/lib/cmd/ext.js

@@ -1,4 +1,3 @@
-#!/usr/bin/env node
 
 const parseArgs = require('minimist')
 
@@ -43,7 +42,7 @@ if (argv.help) {
   process.exit(0)
 }
 
-const { warn } = require('../lib/helpers/logger')
+const { warn } = require('../helpers/logger')
 
 if (argv._.length !== 0 && argv._.length !== 2) {
   console.log()
@@ -53,7 +52,7 @@ if (argv._.length !== 0 && argv._.length !== 2) {
 }
 
 async function run (action, name) {
-  const Extension = require('../lib/app-extension/Extension')
+  const Extension = require('../app-extension/Extension')
   const extension = new Extension(name)
 
   await extension[
@@ -64,7 +63,7 @@ async function run (action, name) {
 }
 
 if (argv._.length === 0) {
-  const extensionJson = require('../lib/app-extension/extension-json')
+  const extensionJson = require('../app-extension/extension-json')
   extensionJson.list()
 }
 else {