use custom pandoc writer to preserve raw html blocks #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
reviewed
Sep 25, 2024
juliasilge
approved these changes
Sep 25, 2024
jjallaire
approved these changes
Sep 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
Uses a custom pandoc writer to preserve raw HTML blocks (
{=html}) when using Visual Editor.This was due to a Pandoc 3.2+ change that was stripping these blocks when we were converting from the AST to markdown.
Note/question: I updated the CHANGELOG and extension version as part of this; not sure if that's appropriate or should be done separately.
The same change will be made separately in RStudio; it will consume this same
md-writer.luascript (rstudio pulls in this repo to obtain panmirror so can grab it from there) andrsessionwill make the same substitution that is happening here.