always dismiss progress indicator after preview output (#823)

vezwork · web-flow · commit 012d457eeda5 · 2025-09-23T12:31:48.000-04:00
* always dismiss progress after preview output

* Update changelog
diff --git a/apps/vscode/CHANGELOG.md b/apps/vscode/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 1.125.0 (Unreleased)
 
 - Fixed an issue where attribute values containing '='s could be truncated in some scenarios (<https://github.com/quarto-dev/quarto/pull/814>).
+- Fixed an issue where a loading spinner for qmd previews wasn't dismissed on preview errors (<https://github.com/quarto-dev/quarto/pull/823>)
 
 ## 1.124.0 (Release on 2025-08-20)
 
diff --git a/apps/vscode/src/providers/preview/preview.ts b/apps/vscode/src/providers/preview/preview.ts
@@ -574,6 +574,7 @@ class PreviewManager {
         }
       }
     }
+    this.progressDismiss()
   }
 
   private progressShow(uri: Uri) {

Original file line number	Diff line number	Diff line change
`@@ -574,6 +574,7 @@ class PreviewManager {`
`574`	`574`	`}`
`575`	`575`	`}`
`576`	`576`	`}`
	`577`	`+ this.progressDismiss()`
`577`	`578`	`}`
`578`	`579`
`579`	`580`	`private progressShow(uri: Uri) {`