-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typst table wrapping to prevent font family and size spill #11113
Fix Typst table wrapping to prevent font family and size spill #11113
Conversation
Thanks for your contribution, @younes-io! As you can see, this fix causes infinite recursion and many of the tests time out. I think this is because it substitutes the table element with a Div containing the table, then recurses in and again tries to convert the table. I can reproduce this locally by checking out your branch and then attempting to e.g.
If this is the correct root cause, you could try testing if the table already has the class |
FWIW, I think this still doesn't work on topdown traversals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the return foo, false
pattern, we don't need the typst-processed
class, right?
remove typst-processed
to avoid churning tests with a temporary change
316a70a
to
6999e08
Compare
I've squashed these commits and moved the fix the specific place and condition where it is needed, and added a test. As noted in #11093, this is a temporary change until we get the fix into Pandoc, and a couple of tests were failing due to unneeded changes to the Typst output. I'd rather avoid the churn of changing the tests twice. Let's see if this passes now! |
Merging. Thanks @younes-io! |
Thank you @gordonwoodhull for your help & the fix! BTW, I was trying to set up a Thank you again! And thanks to @cscheid for being so patient as well! 😄 |
Fixes #11093