Repository navigation
Commit 8214573
committed
Fix chrome-headless-shell binary name lookup on Linux arm64
The Playwright CDN arm64 mirror now redirects to the same
chrome-for-testing-public bucket used for every other platform (see
previous commit), so the archive layout changed too: it ships
chrome-headless-shell-linux-arm64/chrome-headless-shell, not
Playwright's older chrome-linux/headless_shell. With the previous
arm64 special-case still in place, chromeHeadlessShellBinaryName()
searched for a binary that no longer exists in the archive, so
installation looked like it downloaded fine but never registered as
installed.
Verified against the real archive (downloaded via
playwrightCdnDownloadUrl) rather than by exercising the arm64 code
path directly, since isPlaywrightCdnPlatform() auto-detects the host
platform and this bug is only reachable on arm64 hardware.
Removed the now-inapplicable "Playwright arm64 layout" unit test
fixture and stale comments describing the old chrome-linux/headless_shell
layout.1 parent 8290a75 commit 8214573
3 files changed
Lines changed: 41 additions & 33 deletions
File tree
- src/tools/impl
- tests/unit/tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 14 | + | |
18 | 15 | | |
19 | 16 | | |
20 | 17 | | |
| |||
24 | 21 | | |
25 | 22 | | |
26 | 23 | | |
27 | | - | |
28 | | - | |
29 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
30 | 28 | | |
31 | 29 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 30 | + | |
37 | 31 | | |
38 | 32 | | |
39 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | 133 | | |
153 | 134 | | |
154 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
103 | | - | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
172 | 205 | | |
173 | 206 | | |
174 | 207 | | |
| |||
0 commit comments