Skip to content

Disable logger exporter metrics if metrics disabled #47600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable logger exporter metrics if metrics disabled #47600

wants to merge 1 commit into from

Conversation

brunobat
Copy link
Contributor

Also, clarify documentation of properties enabling OTel logs and metrics

@brunobat brunobat requested a review from rsvoboda April 29, 2025 16:41
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2025

/cc @radcortez (opentelemetry)

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

😭 Deploy PR Preview failed.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
rsvoboda
rsvoboda requested changes Apr 29, 2025
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did quick check through the text, I will try the functionality tmr.

@gsmet gsmet changed the title Disable logger exporter metrics if metrics disabled. Disable logger exporter metrics if metrics disabled Apr 30, 2025
@brunobat
Disable logger exporter metrics if metrics disabled.
42e8fce 
Clarify documentation of properties enabling OTel logs and metrics
@brunobat brunobat requested a review from rsvoboda April 30, 2025 13:10
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 30, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 42e8fce.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 42e8fce.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

geoand
geoand reviewed May 6, 2025
View reviewed changes
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeReinitializedClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
import io.quarkus.deployment.builditem.nativeimage.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use star imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@geoand geoand geoand left review comments

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
area/tracing triage/flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brunobat @rsvoboda @gsmet @geoand