Do not rely on Quarkus BOM to resolve the version for analytics #45477
Conversation
People can have custom BOMs
quarkus-bot
bot
added
area/devtools
| return applicationModel.getPlatforms().getImportedPlatformBoms().stream() | ||
| .filter(artifactCoords -> artifactCoords.getArtifactId().equals("quarkus-bom")) | ||
| return applicationModel.getDependencies().stream() | ||
| .filter(artifactCoords -> artifactCoords.getArtifactId().equals("quarkus-bootstrap-core")) |
There was a problem hiding this comment.
What do you think @aloubyansky ?
There was a problem hiding this comment.
I wouldn't do this, assuming we want the platform version. But I'm curious why the version is not detectable. It also depends what we want as "Quarkus version".
The difference is that, currently it's the platform version and while this will be the core, that may not be aligned downstream, just in case.
Second point, it's not exactly about direct quarkus-bom imports. Even there is a hierarchy of parent POMs and BOM imports, including flattening, the quarkus-bom should be detectable unless some (fingerprinting) part of it is removed.
There was a problem hiding this comment.
right, we want platform version
There was a problem hiding this comment.
There is noticeable portion of N/A versions reported in build time analytics, so I thought it's because of custom bom. We should look into the reasons why https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/analytics-common/src/main/java/io/quarkus/analytics/AnalyticsService.java#L260 resolves the version as N/A.
My theory was false :/ I tried my custom BOM and io.quarkus.platform:quarkus-bom was reported by applicationModel.getPlatforms().getImportedPlatformBoms()
Can it be that people use custom builds of Quarkus?
There was a problem hiding this comment.
Can it be that people use custom builds of Quarkus?
Theoretically. But given the amount, I doubt that's the reality.
There was a problem hiding this comment.
I agree there are too many.
Do not rely on Quarkus BOM to resolve the version for analytics
People can have custom BOMs