Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DB2 Driver to 12.1.0.0 #45448

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jan 8, 2025

  • Bump DB2 Driver to 12.1.0.0
  • Reinitialize sun.nio.ch.NioSocketImpl

Resurrection of #44752 working around the TCP_KEEPIDLE issue till oracle/graal#10431 gets merged and backported upstream.

Fixes #45159

@zakkak zakkak requested review from Sanne and gastaldi January 8, 2025 15:20
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/jdbc Issues related to the JDBC extensions labels Jan 8, 2025
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Hope CI is happy now

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's probably our last remnant of non-Jakarta stuff, awesome!

This comment has been minimized.

Copy link

github-actions bot commented Jan 8, 2025

🎊 PR Preview 7c545fb has been successfully built and deployed to https://quarkus-pr-main-45448-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zakkak !

@zakkak
Copy link
Contributor Author

zakkak commented Jan 8, 2025

CI failures look infra-related

io.fabric8.maven.docker.access.DockerAccessException: error pulling image configuration: download failed after attempts=1: error parsing HTTP 403 response body: no error details found in HTTP response body: "{"status":403,"message":"Error: invalid URL signature"}"

@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 8, 2025

This comment has been minimized.

@zakkak
Copy link
Contributor Author

zakkak commented Jan 9, 2025

JVM tests timed out, as they appear to be timing out on main as well. As a result the failures seem unrelated to this PR but I still don't feel comfortable merging it. @gsmet WDYT?

gastaldi and others added 2 commits January 9, 2025 10:14
It also uses the jakarta.transaction packages, so no need to transform it
Workaround till oracle/graal#10431 gets merged
and backported to all supported versions
@gsmet gsmet force-pushed the 2025-01-08-bumb-db2-jdbc branch from 90202f3 to a23633a Compare January 9, 2025 09:14
@gsmet
Copy link
Member

gsmet commented Jan 9, 2025

Yeah it's due to a bug in SmallRye FT. I'm rebasing all failing PRs.

Copy link

quarkus-bot bot commented Jan 9, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit a23633a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 9, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a23633a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

@zakkak zakkak merged commit 1c42adb into quarkusio:main Jan 9, 2025
54 checks passed
@zakkak zakkak deleted the 2025-01-08-bumb-db2-jdbc branch January 9, 2025 15:46
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 9, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/jdbc Issues related to the JDBC extensions triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test JPA - DB2 fails to build when using GraalVM for JDK 25
4 participants