-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with generating config files for the IDEs #42677
Draft
gsmet
wants to merge
6
commits into
quarkusio:main
Choose a base branch
from
gsmet:ide-experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 PR Preview 4cab5df has been successfully built and deployed to https://quarkus-pr-main-42677-preview.surge.sh/version/main/guides/
|
quarkus-bot
bot
added
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/hibernate-validator
Hibernate Validator
area/hibernate-orm
Hibernate ORM
area/hibernate-search
Hibernate Search
labels
Aug 22, 2024
gsmet
force-pushed
the
ide-experiment
branch
2 times, most recently
from
September 5, 2024 16:48
3dc7def
to
7df1e97
Compare
This was referenced Sep 10, 2024
gsmet
force-pushed
the
ide-experiment
branch
from
September 10, 2024 14:22
7df1e97
to
1f3b5b1
Compare
quarkus-bot
bot
added
the
area/platform
Issues related to definition and interaction with Quarkus Platform
label
Sep 10, 2024
This was referenced Sep 11, 2024
gsmet
force-pushed
the
ide-experiment
branch
2 times, most recently
from
September 13, 2024 17:55
0216181
to
10ffdcb
Compare
This plugin is used to generate the configuration metadata for each extension. This metadata follows the Spring config metadata format: The plugin is installed at the package phase and assembles everything that is in the classpath. The metadata is augmented with some additional Quarkus metadata.
In the light of the Spring config metadata, let's get rid of sourceClass and let's avoid using sourceType for the field/method type as it's confusing. Fixes quarkusio#43175
When we attach the config metadata, we need to consider only the properties of the current extension and not those from potential internal/common extensions: these will be published for the internal/common extensions themselves.
It is far from being perfect and typically doesn't handle tables. But it's a good first step.
We probably need to improve on the error reporting as to not fail entirely if we find an icon that is not supported. Related to quarkusio#43287
gsmet
force-pushed
the
ide-experiment
branch
from
September 30, 2024 16:22
10ffdcb
to
1bcc0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/hibernate-orm
Hibernate ORM
area/hibernate-search
Hibernate Search
area/hibernate-validator
Hibernate Validator
area/platform
Issues related to definition and interaction with Quarkus Platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be merged.
It is a quick experiment to show what we can do to generate files containing the configuration properties for the IDEs. It can be used to experiment and adjust the format.
This is part of the work in the working group: #42671 .
A command similar to:
can be handy to share the output.
(Adapt the command if the file names are changed as we might not publish JSON files and we might follow some other convention)