[Maven 4] Replace ${maven.multiModuleProjectDirectory} with ${session.rootDirectory} #42440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/dependencies
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
|
This should be removed as well; |
|
Ah yes, it makes perfect sense, let me adjust. |
…tory}
This will be when we migrate to Maven 4.
While Maven 3.9.2 also introduces ${session.rootDirectory}, it is not
usable in POM files, only in the Maven config itself.
gsmet
force-pushed
the
drop-maven.multiModuleProjectDirectory
branch
from
cdcb0e6
to
de2205e
Compare
|
done! |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Documentation Build | Build |
Logs | Raw logs | 🚧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be when we migrate to Maven 4.
While Maven 3.9.2 also introduces ${session.rootDirectory}, it is not usable in POM files, only in the Maven config itself.
/cc @aloubyansky for your awareness.
Fixes #42430