Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Eclipse Sisu (CDI implementation) #2889

Closed
wants to merge 1 commit into from

Conversation

mariofusco
Copy link
Contributor

…tion processor in org.eclipse.sisu.inject

@gsmet
Copy link
Member

gsmet commented Jun 19, 2019

@stuartwdouglas any idea why we have this dependency coming and why it generates this file in the Kogito case?

@mariofusco
Copy link
Contributor Author

@gsmet @stuartwdouglas apparently the annotation processor in that dependency is explicitly made (God knows why) to generate that javax.inject.Named file, see https://www.eclipse.org/sisu/docs/api/org.eclipse.sisu.inject/reference/org/eclipse/sisu/space/SisuIndexAPT6.html

@mariofusco
Copy link
Contributor Author

@gsmet @stuartwdouglas in reality that jar seems to be explicitly made to be used inside a maven plugin to generate that file, see http://www.eclipse.org/sisu/docs/api/org.eclipse.sisu.mojos/ I think it doesn't make sense to have it among our dependencies

@stuartwdouglas
Copy link
Member

I have no idea what this does, I assume it is part of the internals of JUnit 5.

@emmanuelbernard
Copy link
Member

I'm a noob but should this exclusion be in our bom instead? Otherwise +1 for the exclusiong. Sisu is a CDI impl so we don't want it in.

@emmanuelbernard emmanuelbernard added this to the 0.19.0 milestone Jun 26, 2019
@emmanuelbernard emmanuelbernard changed the title avoid spurious generation of javax.inject.Named file caused by annota… Exclude Eclipse Sisu (CDI implementation) Jun 26, 2019
@gsmet gsmet removed this from the 0.19.0 milestone Jun 26, 2019
@gsmet gsmet added the triage/invalid This doesn't seem right label Jun 26, 2019
gsmet added a commit to gsmet/quarkus that referenced this pull request Jun 26, 2019
It is a CDI implementation and we really don't want it when running our
tests.

It also can generate unwanted files in the case of the Kogito extension
(see quarkusio#2879 and quarkusio#2889).
@gsmet
Copy link
Member

gsmet commented Jun 26, 2019

Closing this one in favor of #2986 for a more general fix.

Typically, the Kogito quickstart did generate a file too so we really need to exclude it from the JUnit artifact.

@gsmet gsmet closed this Jun 26, 2019
gsmet added a commit that referenced this pull request Jun 27, 2019
It is a CDI implementation and we really don't want it when running our
tests.

It also can generate unwanted files in the case of the Kogito extension
(see #2879 and #2889).
dmlloyd pushed a commit to dmlloyd/quarkus that referenced this pull request Jul 11, 2019
It is a CDI implementation and we really don't want it when running our
tests.

It also can generate unwanted files in the case of the Kogito extension
(see quarkusio#2879 and quarkusio#2889).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kogito triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants