-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Eclipse Sisu (CDI implementation) #2889
Conversation
…tion processor in org.eclipse.sisu.inject
@stuartwdouglas any idea why we have this dependency coming and why it generates this file in the Kogito case? |
@gsmet @stuartwdouglas apparently the annotation processor in that dependency is explicitly made (God knows why) to generate that javax.inject.Named file, see https://www.eclipse.org/sisu/docs/api/org.eclipse.sisu.inject/reference/org/eclipse/sisu/space/SisuIndexAPT6.html |
@gsmet @stuartwdouglas in reality that jar seems to be explicitly made to be used inside a maven plugin to generate that file, see http://www.eclipse.org/sisu/docs/api/org.eclipse.sisu.mojos/ I think it doesn't make sense to have it among our dependencies |
I have no idea what this does, I assume it is part of the internals of JUnit 5. |
I'm a noob but should this exclusion be in our bom instead? Otherwise +1 for the exclusiong. Sisu is a CDI impl so we don't want it in. |
It is a CDI implementation and we really don't want it when running our tests. It also can generate unwanted files in the case of the Kogito extension (see quarkusio#2879 and quarkusio#2889).
Closing this one in favor of #2986 for a more general fix. Typically, the Kogito quickstart did generate a file too so we really need to exclude it from the JUnit artifact. |
It is a CDI implementation and we really don't want it when running our tests. It also can generate unwanted files in the case of the Kogito extension (see quarkusio#2879 and quarkusio#2889).
…tion processor in org.eclipse.sisu.inject