Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating quarkus 3.2 -> 3.8 fails with opentracing dependency #42201

Open
mocenas opened this issue Jul 29, 2024 · 8 comments
Open

Updating quarkus 3.2 -> 3.8 fails with opentracing dependency #42201

mocenas opened this issue Jul 29, 2024 · 8 comments
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/smallrye area/tracing kind/bug Something isn't working

Comments

@mocenas
Copy link
Contributor

mocenas commented Jul 29, 2024

Describe the bug

Using quarkus CLI 3.12.3. I create project on stream 3.2 (version 3.2.12.Final), add dependency:

<dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-smallrye-opentracing</artifactId>
      <version>3.12.3</version>
</dependency>

and start CLI update to stream 3.8 (to 3.8.5). Update fails on opentracing dependency not having the version set. After update, pom.xml contains dependency:

<dependency>
   <groupId>io.quarkiverse.opentracing</groupId>
   <artifactId>quarkus-smallrye-opentracing</artifactId>
</dependency>

which should have the version set as well, according to https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/resources/quarkus-updates/core/3.6.yaml

If I update to current main (3.12.3) it works fine, but updating to 3.8 fails.
Also doing the update for quarkus CLI v. 3.8.5 makes the update return success, but no changes are actually made.

I'm attaching log from update command
update.log

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

  1. Create an app - quarkus create app app --stream=3.2 -Dquarkus.analytics.disabled=true
  2. Add dependency to pom.xml:
    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-smallrye-opentracing</artifactId>
      <version>3.12.3</version>
    </dependency>
  1. Exec quarkus update quarkus update --stream=3.8

Output of uname -a or ver

No response

Output of java -version

17

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

quarkus CLI 3.12.3

Additional information

No response

@mocenas mocenas added the kind/bug Something isn't working label Jul 29, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2024

/cc @brunobat (tracing), @radcortez (tracing)

@rsvoboda rsvoboda added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Sep 20, 2024
@rsvoboda
Copy link
Member

/CC @gsmet @aloubyansky

@brunobat
Copy link
Contributor

Opentracing is not supported anymore.

@rsvoboda
Copy link
Member

Update tool should at least point to io.quarkiverse.opentracing:quarkus-smallrye-opentracing:1.0.0

Is it possible to print a warning about usage of deprecated extension?

@michalvavrik
Copy link
Member

Update tool should at least point to io.quarkiverse.opentracing:quarkus-smallrye-opentracing:1.0.0

It seems SR OT is on Quarkus 3.6 https://github.com/quarkiverse/quarkus-smallrye-opentracing/blob/main/pom.xml#L30. It doesn't seem like a good idea to use it with 3.8.

@brunobat
Copy link
Contributor

@michalvavrik @rsvoboda The extension is not supported or maintained:

Screenshot 2024-09-23 at 09 02 59

@michalvavrik
Copy link
Member

got it, let's close this; thanks

@rsvoboda
Copy link
Member

OK, we do not support SR OT, shouldn't update tool fail in that case so the user adjusts the app?

The app was build-able and runnable, but after running the tool it's not buildable anymore.

I would expect that the update tool would fail with a message that SR OT is no longer maintained and the app needs some rework to be supported with the latest Quarkus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/smallrye area/tracing kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants