-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating quarkus 3.2 -> 3.8 fails with opentracing dependency #42201
Comments
/cc @brunobat (tracing), @radcortez (tracing) |
/CC @gsmet @aloubyansky |
Opentracing is not supported anymore. |
Update tool should at least point to Is it possible to print a warning about usage of deprecated extension? |
It seems SR OT is on Quarkus 3.6 https://github.com/quarkiverse/quarkus-smallrye-opentracing/blob/main/pom.xml#L30. It doesn't seem like a good idea to use it with 3.8. |
@michalvavrik @rsvoboda The extension is not supported or maintained: |
got it, let's close this; thanks |
OK, we do not support SR OT, shouldn't update tool fail in that case so the user adjusts the app? The app was build-able and runnable, but after running the tool it's not buildable anymore. I would expect that the update tool would fail with a message that SR OT is no longer maintained and the app needs some rework to be supported with the latest Quarkus. |
Describe the bug
Using quarkus CLI 3.12.3. I create project on stream 3.2 (version 3.2.12.Final), add dependency:
and start CLI update to stream 3.8 (to 3.8.5). Update fails on opentracing dependency not having the version set. After update, pom.xml contains dependency:
which should have the version set as well, according to https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/resources/quarkus-updates/core/3.6.yaml
If I update to current main (3.12.3) it works fine, but updating to 3.8 fails.
Also doing the update for quarkus CLI v. 3.8.5 makes the update return success, but no changes are actually made.
I'm attaching log from update command
update.log
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
quarkus create app app --stream=3.2 -Dquarkus.analytics.disabled=true
quarkus update --stream=3.8
Output of
uname -a
orver
No response
Output of
java -version
17
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)quarkus CLI 3.12.3
Additional information
No response
The text was updated successfully, but these errors were encountered: