Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Global) Cookie encryption #34192

Open
cescoffier opened this issue Jun 21, 2023 · 2 comments
Open

(Global) Cookie encryption #34192

cescoffier opened this issue Jun 21, 2023 · 2 comments
Labels
area/security kind/epic Large issue with links to sub-issues

Comments

@cescoffier
Copy link
Member

Description

How can we provide support for global cookie encryption - in a cloud-native manner (multiple instances of the application should be able to read and write the same cookie).

Analysis

(links to analysis docs containing architecture design work, requirements gathering, etc)

@cescoffier cescoffier added the kind/epic Large issue with links to sub-issues label Jun 21, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2023

/cc @pedroigor (bearer-token), @sberyozkin (bearer-token,jwt,security)

@sberyozkin
Copy link
Member

Hi @cescoffier This is probably a duplicate of #33277.

Multiple extensions have their own way of managing the cookies relevant to them.
Lets take Form and OIDC for example. In this case having the same cookie used by both Form and OIDC makes no sense - because noone will use Form and OIDC at the same time, but also, OIDC session cookie lifetime and other properties are controlled at the OIDC provider side (ID token configuration etc), for Form - locally in Quarkus.

But the uniform cookie encryption is indeed worth it, so that multiple pods, can read the encrypted cookie. Each extension has a way to configure an encryption key. While property names are different, all of them can use for example a single instance of ConfigSource to fetch this encryption from the encryption store of some sort. CredenatialsProvider is another option

Right now I'm not sure there is much scope to this issue as we have the options to share the same encryption key between all extensions encrypting the cookies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security kind/epic Large issue with links to sub-issues
Projects
None yet
Development

No branches or pull requests

3 participants