-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Smallrye Reactive Messaging SQS #1414
Comments
@adampoplawski smallrye is supported directly by quarkus core. I would open an issue there. Smallrye use only the netty transport implementation so that the whole purpose of this extension is a bit over complicated. I guess like for Apache Camel aws2 SQS which only use Apache HTTP client transport, there will be a dedicated and separated extension for smallrye. The only things that should be needed for quarkus to support aws sdk with
and a dependency on Last, like with the Apache Camel connector, you may be able to reuse an instance from this extension as the smallrye connector allows to inject an SqsClient instance. @ozangunalp what do you think ? |
I'll respond here first: The connector was contributed upstream to the Smallrye Reactive Messaging, but it was designed to work with a provided The integration is very straightforward, as @scrocquesel mentioned. There is a quickstart here: https://github.com/quarkusio/quarkus-quickstarts/tree/main/amazon-sqs-connector-quickstart With the following dependencies :
We could contribute to this repository, an extension putting all these dependencies together. |
If we don't need a specific quarkus extension for the connector itself, it is all good. Is it documented somewhere that not all smallrye connectors require a quarkus extension. |
Maybe I'll add a line in https://quarkus.io/guides/messaging about that. |
@ozangunalp I will start with https://github.com/quarkusio/quarkus-quickstarts/tree/main/amazon-sqs-connector-quickstart and will ping you if I will get stuck |
@adampoplawski thank you for looking into this. Ping me if you have any questions. You can check the quickstart for required dependencies. |
@ozangunalp I have created simple demo for me https://github.com/adampoplawski/quarkus-sqs |
Hello |
The quick start is enough for me now. We may need to wrap with a dedicated extension when the smallrye connector supports multiple name client. |
@scrocquesel thx. So I will leave it with you and will contribute to other issue :) |
here is a draft for a simple wrapper extension : #1431 Feel free to change anything needed. |
Thanks, @adampoplawski could you try add the quick start sample as an integration test in the integration test module ? |
@scrocquesel yes, not today but I will look next week. |
@scrocquesel @ozangunalp Can we somehow get quarkiverse-aws from this brach to add integration test locally? |
Create another PR based on this branch |
#1438 is off from a branch of this repo. Feel free to contribute the branch with PRs. |
@scrocquesel |
@scrocquesel I will take care of integration test this week :) |
@scrocquesel how can I push to this repo, to separate branch? Maybe there is instruction for it? |
Push to your fork and open a pull request |
The extension has been released. I opened another issue for the integration test #1466 Thank you all for this contribution. |
Around April SQS support was added to Smallrye Reactive Messaging. I asked on Zulip if Quarkus integration is planned and were transferred here. Is this topic considered?
For potential reference https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/smallrye.20reactive.20messaging.20SQS.20support.
Thx for support
The text was updated successfully, but these errors were encountered: