Added nasdaq provider #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some tests, similar like we have for other data providers |
|
I can't find a test for the quandl data provider which this is based on. The challenge with test this is the API key. |
|
We need to write new tests. Let's also not focus that much on Quandl, as this is very old data provider (a few years) and some parts of the code will require better testing and implementation. We will prepare a CR. |
|
Please could you contact me directly via email so we can discuss what tests are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nasdaq data provider is a replacement for quandl which is now delivered via Nasdaq Data Link.
It is essentially a copy and rename of the quandl data provider.