ruff - enable and fix pylint-equivalent rules #7420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the rule for Python sources, ignore rule for Jupyter notebooks.
Remove LazyLoader of `op_tree` after checking that each cirq module can be imported as the first one in Python session.
All such instances were intentional to validate equality logic.
All such instances were intentional to validate unequality logic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7420 +/- ##
==========================================
- Coverage 98.69% 98.69% -0.01%
==========================================
Files 1112 1112
Lines 97921 97910 -11
==========================================
- Hits 96643 96632 -11
Misses 1278 1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
requested review from
mrwojtek,
vtomole,
a team,
wcourtney and
verult
as code owners
|
note - this can be reviewed commit-by-commit. |
mhucka
approved these changes
Jun 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
Enable and fix ruff rules corresponding to enabled pylint checks. Disable pylint `syntax-error` checks as syntax is always checked by ruff. No change in the effective code. Partially implements quantumlib#7371
ddddddanni
pushed a commit
to ddddddanni/Cirq
that referenced
this pull request
Jul 15, 2025
Enable and fix ruff rules corresponding to enabled pylint checks. Disable pylint `syntax-error` checks as syntax is always checked by ruff. No change in the effective code. Partially implements quantumlib#7371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable and fix ruff rules corresponding to enabled pylint checks.
Disable pylint
syntax-errorchecks as syntax is always checked by ruff.No change in the effective code.
Partially implements #7371