Add Serialization and Deserialization Support of FSimViaModelTag. #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6539 +/- ##
==========================================
- Coverage 97.78% 97.78% -0.01%
==========================================
Files 1107 1107
Lines 95178 95182 +4
==========================================
+ Hits 93069 93072 +3
- Misses 2109 2110 +1 ☔ View full report in Codecov by Sentry. |
BichengYing
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
verult
approved these changes
Apr 1, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
…antumlib#6539) * Add Serialization and Deserialization Support of FSimViaModelTag. * Fix the lint * Update program_pb2.pyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support of serialization and deserialization of
FSimGate(theta, phi).with_tags(FSimViaModelTag()), which is needed for the support the external user to use arbitrary angle FSim. With this tag, the internal translation of FSim will use polynomial instead of relied on the a few choices of specified angles.CC: @eliottrosenberg