Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-daily notebook failures on Mac OS X #6444

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Feb 6, 2024

Use common version specification for quimb and numba as defined in
contrib/requirements.txt. And install notebook dependencies for all CI platforms.

Avoid incompatible versions of quimb and numba in notebook environments.

Example failure: https://github.com/quantumlib/Cirq/actions/runs/7792626671/job/21250976788#step:6:580

Fix verified at https://github.com/quantumlib/Cirq/actions/runs/7805446772

Related to #6336

Fixes ci-daily failure on Mac due to incompatible versions of quimb and numba.
@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 6, 2024
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2c6f3c) 97.81% compared to head (d56405c) 97.81%.
Report is 1 commits behind head on main.

❗ Current head d56405c differs from pull request most recent head 2734cf2. Consider uploading reports for the commit 2734cf2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6444      +/-   ##
==========================================
- Coverage   97.81%   97.81%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       97198    97198              
==========================================
- Hits        95078    95074       -4     
- Misses       2120     2124       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as ready for review February 6, 2024 22:13
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners February 6, 2024 22:13
@pavoljuhas pavoljuhas enabled auto-merge (squash) February 7, 2024 21:59
@pavoljuhas pavoljuhas merged commit 36e91b0 into quantumlib:main Feb 7, 2024
32 checks passed
@pavoljuhas pavoljuhas deleted the fix-ci-daily-on-mac branch February 7, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants