-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm build_rtd_docs CI job and its dependencies #6417
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6417 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1111 1111
Lines 97115 97115
=======================================
Hits 94994 94994
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there are few more leftovers -
$ git grep -n -i "readthedocs.{0,30}cirq|rtd" | grep -v -i image/png
.dockerignore:24:rtd_docs/generated
.gitignore:25:rtd_docs/generated
.readthedocs.yml:7: - requirements: rtd_docs/requirements.txt
.readthedocs.yml:9: configuration: rtd_docs/conf.py
README.rst:19:.. image:: https://readthedocs.org/projects/cirq/badge/?version=latest
README.rst:20: :target: https://readthedocs.org/projects/cirq/versions/
dev_tools/incremental_coverage.py:24: r'^rtd_docs/.+', # Environment-heavy code.
We should remove the .readthedocs.yml
configuration file as there is nothing to build at RTD now. :-)
The hanging @dstrain115 , @95-martin-orion - can you PTAL? |
Re: @pavoljuhas comment-- someone should be able to disable the workflow by navigating to the @dstrain115 , @95-martin-orion can either of you disable the deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
Fixes #6416