Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm build_rtd_docs CI job and its dependencies #6417

Merged
merged 9 commits into from
Jan 19, 2024

Conversation

senecameeks
Copy link
Collaborator

Fixes #6416

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3eed6b) 97.81% compared to head (00dfb84) 97.81%.
Report is 2 commits behind head on main.

❗ Current head 00dfb84 differs from pull request most recent head ebe1283. Consider uploading reports for the commit ebe1283 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6417   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files        1111     1111           
  Lines       97115    97115           
=======================================
  Hits        94994    94994           
  Misses       2121     2121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senecameeks senecameeks marked this pull request as ready for review January 17, 2024 20:25
@senecameeks senecameeks requested review from vtomole, cduck and a team as code owners January 17, 2024 20:25
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are few more leftovers -

$ git grep -n -i "readthedocs.{0,30}cirq|rtd" | grep -v -i image/png
.dockerignore:24:rtd_docs/generated
.gitignore:25:rtd_docs/generated
.readthedocs.yml:7:      - requirements: rtd_docs/requirements.txt
.readthedocs.yml:9:  configuration: rtd_docs/conf.py
README.rst:19:.. image:: https://readthedocs.org/projects/cirq/badge/?version=latest
README.rst:20:  :target: https://readthedocs.org/projects/cirq/versions/
dev_tools/incremental_coverage.py:24:    r'^rtd_docs/.+',  # Environment-heavy code.

We should remove the .readthedocs.yml configuration file as there is nothing to build at RTD now. :-)

@pavoljuhas
Copy link
Collaborator

The hanging Build docs CI job may need to be somehow deactivated in our GitHub page.

@dstrain115 , @95-martin-orion - can you PTAL?

image

@senecameeks
Copy link
Collaborator Author

Re: @pavoljuhas comment-- someone should be able to disable the workflow by navigating to the Actions tab on github and disabling the workflow. I don't think I have sufficient permissions to do it myself since I'm not seeing an option to do it.

@dstrain115 , @95-martin-orion can either of you disable the deprecated Build Docs CI job on the GUI?

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@senecameeks senecameeks enabled auto-merge (squash) January 19, 2024 18:51
@senecameeks senecameeks merged commit ee56c59 into quantumlib:main Jan 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove build_doc CI job and dependencies
3 participants