Make InternalGate hashable if all gate args are hashable #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
NoureldinYosri
approved these changes
Sep 19, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6294 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 1104 1104
Lines 95841 95854 +13
=======================================
+ Hits 93818 93831 +13
Misses 2023 2023
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
InternalGateincludes a dict in_value_equality_values_, so it is never hashable even if all gate args are hashable. Change to use a frozenset of items instead to make it hashable. We also change to store constructor kwargs directly instead of copying the kwargs dict, since**kwargspassed in to a function is always a unique dictionary which won't alias a caller's dict.