-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if python starts python3 #6239
Check if python starts python3 #6239
Conversation
This bails out when `python` command does not exist or does not start Python 3.
cc: @nafaynajam |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6239 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 1116 1116
Lines 96110 96118 +8
=======================================
+ Hits 93594 93603 +9
+ Misses 2516 2515 -1
☔ View full report in Codecov by Sentry. |
@pavoljuhas I see that you have mentioned me in this issue, could you elaborate how I may be of help?, I see commits in code coverage, is it just to notify me of the changes in it?. |
Hi Nafay, this PR is to address the error on running check/pytest you asked about last Friday. No action is needed, the cc is to let you know about the fix. |
@pavoljuhas Very nice, thanks :-) |
Problem: dev_tools/pypath does not work when
python
command doesnot exist causing a failure in
check/pytest
(PYTHONPATH not set).Solution: Require that
python
starts Python 3.Bail out from the check scripts otherwise.