Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #5637 #5638

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fix for issue #5637 #5638

merged 1 commit into from
Jun 29, 2022

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Jun 29, 2022

The modules.py argument parser does not understand the argument
--list; it needs to be list.

@mhucka
Fix for issue #5637
cf9f93a 
The `modules.py` argument parser does not understand the argument
`--list`; it needs to be `list`.
@mhucka mhucka requested review from a team, vtomole and cduck as code owners June 29, 2022 17:35
@mhucka mhucka requested a review from pavoljuhas June 29, 2022 17:35
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 29, 2022
vtomole
vtomole approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Kind of related: Why is python dev_tools/modules.py print_version failing with ModuleNotFoundError: No module named 'dev_tools' for me?

@vtomole
Copy link
Collaborator

vtomole commented Jun 29, 2022 •
edited
Loading

If i run it in the dev_tools directory it doesn't error out, but doesn't give the correct version either.

(cirq_venv) vtomole@vtomole:~/Cirq/dev_tools$ python3 modules.py print_version
None

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 29, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 29, 2022
@mhucka
Copy link
Contributor Author

mhucka commented Jun 29, 2022

LGTM. Kind of related: Why is python dev_tools/modules.py print_version failing with ModuleNotFoundError: No module named 'dev_tools' for me?

I tried it and it happens to me too. This seems like a bug. Would you like to open a bug report for this? The code in modules.py is kind of gnarly and I'd be interested in studying it and trying to fix whatever the issue is.

@vtomole
Copy link
Collaborator

vtomole commented Jun 29, 2022

Would you like to open a bug report for this?

Please do.

@CirqBot CirqBot merged commit 2333536 into quantumlib:master Jun 29, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 29, 2022
@vtomole vtomole mentioned this pull request Jun 29, 2022
Closed
@mhucka mhucka mentioned this pull request Jul 8, 2022
Closed
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@mhucka @rht
Fix for issue quantumlib#5637 (quantumlib#5638)
80b53d2 
The `modules.py` argument parser does not understand the argument
`--list`; it needs to be `list`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@pavoljuhas pavoljuhas Awaiting requested review from pavoljuhas pavoljuhas was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhucka @vtomole @CirqBot