Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken tutorial on identifying_hardware_changes.ipynb #5588

Open
pavoljuhas opened this issue Jun 23, 2022 · 2 comments
Open

broken tutorial on identifying_hardware_changes.ipynb #5588

pavoljuhas opened this issue Jun 23, 2022 · 2 comments
Assignees
@verult @wcourtney @NoureldinYosri
Labels
area/tutorials kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

The tutorial uses a removed method Device.qubit_set() at

Cirq/docs/tutorials/google/identifying_hardware_changes.ipynb

Line 288 in eb2a1dc

"qubits = device.qubit_set()\n",

@MichaelBroughton found additional issues in the tutorial as detailed at #5582 (comment)

How to reproduce the issue

Failure on notebook execution. The qubit_set() method was removed in eb2a1dc.

Cirq version

0.15.0.dev
@pavoljuhas pavoljuhas added the kind/bug-report Something doesn't seem to work. label Jun 23, 2022
@vtomole
Copy link
Collaborator

vtomole commented Jun 23, 2022 •
edited
Loading

How did this get passed the notebooks check? Do we execute the notebooks on released versions of Cirq?

@dabacon
Copy link
Collaborator

dabacon commented Jun 24, 2022

Notebook tests excludes "**/google/*.ipynb"

@viathor viathor added triage/discuss Needs decision / discussion, bring these up during Cirq Cynque area/tutorials triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verult verult

@wcourtney wcourtney

@NoureldinYosri NoureldinYosri

Labels
area/tutorials kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@dabacon @verult @pavoljuhas @MichaelBroughton @wcourtney @NoureldinYosri @vtomole @viathor