Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution: add a warning message and remove jobs with invalid tasks #523

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Solution: add a warning message and remove jobs with invalid tasks #523

merged 3 commits into from
Oct 4, 2022

Conversation

dannielb
Copy link
Contributor

@dannielb dannielb commented Oct 4, 2022

Hello!

Proposal:

At Quantum startup, when detected that a mfa task is not a valid function, ignore the job configuration and show a warning message.

closes #507

@dannielb dannielb marked this pull request as ready for review October 4, 2022 00:26
@dannielb dannielb mentioned this pull request Oct 4, 2022
Closed
maennchen
maennchen approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dannielb!
If the CI passes, we’re good to go 😊

@coveralls
Copy link

Pull Request Test Coverage Report for Build 22b8db2346aa33f619f4e69853f27e7439236e89-PR-523

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 86.486%
Totals Coverage Status
Change from base Build ac74242ad0f26db2970d6c122c3b90b64b64381d: 0.8%
Covered Lines: 352
Relevant Lines: 407
💛 - Coveralls

@maennchen maennchen merged commit 67799a5 into quantum-elixir:main Oct 4, 2022
@Kitton Kitton mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the existence of modules and functions in the jobs configuration at startup
3 participants
@dannielb @coveralls @maennchen