Skip to content

Commit be039d7

Browse files
author
Scott Sanderson
committed
MAINT: Update supported IPython/Notebook versions.
1 parent 5fad3f6 commit be039d7

File tree

7 files changed

+32
-17
lines changed

7 files changed

+32
-17
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ python:
66
- "3.5"
77
- "3.6"
88
env:
9-
- NB_VERSION=4
109
- NB_VERSION=5
10+
- NB_VERSION=6
1111
- FLAKE8=true NB_VERSION=5
1212
- NOTEST=true NB_VERSION=5
1313

notebook4_constraints.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.

notebook6_constraints.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
notebook<7

pgcontents/tests/test_pgcontents_api.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
from six import iteritems
2525

2626
from IPython.utils.tempdir import TemporaryDirectory
27+
from notebook.tests.launchnotebook import assert_http_error
2728
from requests import HTTPError
2829

2930
from ..constants import UNLIMITED
@@ -50,8 +51,12 @@
5051
TEST_DB_URL,
5152
)
5253
from ..utils.ipycompat import (
53-
APITest, Config, FileContentsManager, GenericFileCheckpoints, to_os_path,
54-
assert_http_error)
54+
APITest,
55+
Config,
56+
FileContentsManager,
57+
GenericFileCheckpoints,
58+
to_os_path,
59+
)
5560
from ..utils.sync import walk, walk_dirs
5661

5762

pgcontents/utils/ipycompat.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
Utilities for managing compat between notebook versions.
33
"""
44
import notebook
5-
if notebook.version_info[0] >= 6: # noqa
6-
raise ImportError("Jupyter Notebook versions 6 and up are not supported.")
75

86
from traitlets.config import Config
97
from notebook.services.contents.checkpoints import (
@@ -21,7 +19,6 @@
2119
from notebook.services.contents.tests.test_contents_api import (
2220
APITest
2321
)
24-
from notebook.tests.launchnotebook import assert_http_error
2522
from notebook.utils import to_os_path
2623
from nbformat import from_dict, reads, writes
2724
from nbformat.v4.nbbase import (
@@ -45,7 +42,6 @@
4542
__all__ = [
4643
'APITest',
4744
'Any',
48-
'assert_http_error',
4945
'Bool',
5046
'Checkpoints',
5147
'Config',

setup.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,24 @@ def main():
4545
'Programming Language :: Python',
4646
'Topic :: Database',
4747
],
48-
install_requires=reqs,
48+
install_requires=[
49+
'SQLAlchemy>=1.0.5',
50+
'alembic>=0.7.6',
51+
'click>=3.3',
52+
'cryptography>=1.4',
53+
'psycopg2>=2.6.1',
54+
'six>=1.9.0',
55+
'notebook>=5.0',
56+
],
4957
extras_require={
50-
'test': test_reqs,
58+
'test': [
59+
'notebook[test]',
60+
'nose',
61+
'nose-ignore-docstring',
62+
'flake8',
63+
'requests',
64+
'mock',
65+
],
5166
},
5267
scripts=[
5368
'bin/pgcontents',

tox.ini

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
[tox]
2-
envlist=py{27,35}-notebook4,py{27,35,36}-notebook5,flake8,notest
2+
envlist=py{27,35,36}-notebook5,py{35,36}-notebook6,py36-latest,flake8,notest
33
skip_missing_interpreters=True
44

55
[testenv]
66
whitelist_externals =
77
createdb
88

99
install_command =
10-
py{27,35,36}-notebook4: pip install -c notebook4_constraints.txt {opts} {packages}
1110
py{27,35,36}-notebook5: pip install -c notebook5_constraints.txt {opts} {packages}
12-
flake8,notest: pip install {opts} {packages}
11+
py{35,36}-notebook6: pip install -c notebook6_constraints.txt {opts} {packages}
12+
flake8,notest,py36-latest: pip install {opts} {packages}
1313

1414
deps =
15-
py{27,35,36}-notebook{4,5}: .[test]
15+
py{27,35,36}-notebook{5,6}: .[test]
1616
flake8: flake8
1717
notest: .
1818

1919
commands =
20-
py{27,35,36}-notebook{4,5}: -createdb pgcontents_testing
21-
py{27,35,36}-notebook{4,5}: nosetests pgcontents/tests
20+
py{27,35,36}-notebook{5,6}: -createdb pgcontents_testing
21+
py{27,35,36}-notebook{5,6}: nosetests pgcontents/tests
2222
flake8: flake8 pgcontents
2323
notest: python -c 'from pgcontents.utils.ipycompat import *'

0 commit comments

Comments
 (0)