-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hanging on unclosed tag #302
Comments
🤦 I'm having the same issue. It's hanging for about 2min in my case |
Same here 😕 |
@eddyw @pawelrychlik Can you confirm the versions that you're on? Might help to see if this was changed recently. I'm experiencing this on 6.10.2. |
6.11.1, i.e. latest as of now |
Yeah, this is a hard problem to solve. Arbitrary HTML in markdown is always an edge case, so I'm not keen to spend too much time working on fixing this honestly. If someone wants to take a stab at it in a PR, i'm open to looking at it. |
Is there a world in which there’s simply a reasonable, possibly configurable, limit on how many lines or additional elements will be considered before terminating the attempt at a match? In other words, limiting the number of lines or characters allowed as the children in the regex.
|
Had a recent issue with builds hanging when a closing HTML tag was missed at the top of a long document. I think the regular expression matching was choking while trying to match over 300 lines non-greedily. If I change the tag to another that isn't used elsewhere in the markdown, the document parses quickly.
Example problem:
To reproduce, paste this shortened markdown snippet into the demo site. This will cause the thread to hang for a while (~5-15s). Longer files seem to increase processing time exponentially.
The text was updated successfully, but these errors were encountered: